components/gcm_driver/fake_gcm_driver.cc - Issue 1785613006: Make GCMDriver::GetInstanceIDHandler protected, to avoid misuse

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/gcm_driver/fake_gcm_driver.cc

Issue 1785613006: Make GCMDriver::GetInstanceIDHandler protected, to avoid misuse (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address peter's nits Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/gcm_driver/fake_gcm_driver.cc

diff --git a/components/gcm_driver/fake_gcm_driver.cc b/components/gcm_driver/fake_gcm_driver.cc

index 390ca1a0cb891616d1229e78a1d269a01b797f9f..f4ae62018dd892f9908a81b0b441cc76e3bdb16d 100644

--- a/components/gcm_driver/fake_gcm_driver.cc

+++ b/components/gcm_driver/fake_gcm_driver.cc

@@ -100,7 +100,7 @@ void FakeGCMDriver::SetLastTokenFetchTime(const base::Time& time) {

void FakeGCMDriver::WakeFromSuspendForHeartbeat(bool wake) {

}

-InstanceIDHandler* FakeGCMDriver::GetInstanceIDHandler() {

+InstanceIDHandler* FakeGCMDriver::GetInstanceIDHandlerInternal() {

return NULL;

}

« no previous file with comments | « components/gcm_driver/fake_gcm_driver.h ('k') | components/gcm_driver/gcm_driver.h » ('j') | no next file with comments »