Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1336)

Unified Diff: components/gcm_driver/instance_id/instance_id_android.cc

Issue 1785613006: Make GCMDriver::GetInstanceIDHandler protected, to avoid misuse (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address peter's review comments Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/gcm_driver/instance_id/instance_id_android.cc
diff --git a/components/gcm_driver/instance_id/instance_id_android.cc b/components/gcm_driver/instance_id/instance_id_android.cc
index 86542ca8ba23f34b971cc4f9109b5cbac6d71238..961156761f9e3e638b0b6ed95b634cc29f91afc3 100644
--- a/components/gcm_driver/instance_id/instance_id_android.cc
+++ b/components/gcm_driver/instance_id/instance_id_android.cc
@@ -11,13 +11,13 @@ namespace instance_id {
// static
scoped_ptr<InstanceID> InstanceID::Create(const std::string& app_id,
- gcm::GCMDriver* gcm_driver) {
- return make_scoped_ptr(new InstanceIDAndroid(app_id));
+ gcm::InstanceIDHandler* handler) {
+ return make_scoped_ptr(new InstanceIDAndroid(app_id, handler));
}
-InstanceIDAndroid::InstanceIDAndroid(const std::string& app_id)
- : InstanceID(app_id) {
-}
+InstanceIDAndroid::InstanceIDAndroid(const std::string& app_id,
+ gcm::InstanceIDHandler* handler)
+ : InstanceID(app_id, handler) {}
InstanceIDAndroid::~InstanceIDAndroid() {
}

Powered by Google App Engine
This is Rietveld 408576698