components/gcm_driver/instance_id/fake_gcm_driver_for_instance_id.h - Issue 1785613006: Make GCMDriver::GetInstanceIDHandler protected, to avoid misuse

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/gcm_driver/instance_id/fake_gcm_driver_for_instance_id.h

Issue 1785613006: Make GCMDriver::GetInstanceIDHandler protected, to avoid misuse (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address peter's review comments Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/gcm_driver/gcm_driver_desktop_unittest.cc ('k') | components/gcm_driver/instance_id/fake_gcm_driver_for_instance_id.cc » ('j') | components/gcm_driver/instance_id/instance_id.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/gcm_driver/instance_id/fake_gcm_driver_for_instance_id.h

diff --git a/components/gcm_driver/instance_id/fake_gcm_driver_for_instance_id.h b/components/gcm_driver/instance_id/fake_gcm_driver_for_instance_id.h

index 9d6b77ac9c568619a783ba7f01e25587f5f1bb32..c8e9ab7eb9c3efe6428f2c2229eeb37e3a93012e 100644

--- a/components/gcm_driver/instance_id/fake_gcm_driver_for_instance_id.h

+++ b/components/gcm_driver/instance_id/fake_gcm_driver_for_instance_id.h

@@ -22,7 +22,7 @@ class FakeGCMDriverForInstanceID : public gcm::FakeGCMDriver,

~FakeGCMDriverForInstanceID() override;

// FakeGCMDriver overrides:

- gcm::InstanceIDHandler* GetInstanceIDHandler() override;

+ gcm::InstanceIDHandler* GetInstanceIDHandlerInternal() override;

// InstanceIDHandler overrides:

void GetToken(const std::string& app_id,