components/gcm_driver/gcm_driver_android.cc - Issue 1785613006: Make GCMDriver::GetInstanceIDHandler protected, to avoid misuse

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/gcm_driver/gcm_driver_android.cc

Issue 1785613006: Make GCMDriver::GetInstanceIDHandler protected, to avoid misuse (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address peter's review comments Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/gcm_driver/gcm_driver_android.h ('k') | components/gcm_driver/gcm_driver_desktop.h » ('j') | components/gcm_driver/instance_id/instance_id.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/gcm_driver/gcm_driver_android.cc

diff --git a/components/gcm_driver/gcm_driver_android.cc b/components/gcm_driver/gcm_driver_android.cc

index 8f345423db36a62f0467c668aa4db8a0a0af4b12..7845bd9922cdda1cd9686681437aa3ce61de12a3 100644

--- a/components/gcm_driver/gcm_driver_android.cc

+++ b/components/gcm_driver/gcm_driver_android.cc

@@ -199,7 +199,7 @@ void GCMDriverAndroid::SetLastTokenFetchTime(const base::Time& time) {

void GCMDriverAndroid::WakeFromSuspendForHeartbeat(bool wake) {

}

-InstanceIDHandler* GCMDriverAndroid::GetInstanceIDHandler() {

+InstanceIDHandler* GCMDriverAndroid::GetInstanceIDHandlerInternal() {

// Not supported for Android.

return NULL;

}