components/gcm_driver/fake_gcm_driver.h - Issue 1785613006: Make GCMDriver::GetInstanceIDHandler protected, to avoid misuse

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/gcm_driver/fake_gcm_driver.h

Issue 1785613006: Make GCMDriver::GetInstanceIDHandler protected, to avoid misuse (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address peter's review comments Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/gcm_driver/fake_gcm_driver.h

diff --git a/components/gcm_driver/fake_gcm_driver.h b/components/gcm_driver/fake_gcm_driver.h

index 01a16c9e0d3bdfa587a653dd5503caedbf927921..363e963d3c2e72ea414c4a627fac0ec5095ff9ba 100644

--- a/components/gcm_driver/fake_gcm_driver.h

+++ b/components/gcm_driver/fake_gcm_driver.h

@@ -40,7 +40,7 @@ class FakeGCMDriver : public GCMDriver {

base::Time GetLastTokenFetchTime() override;

void SetLastTokenFetchTime(const base::Time& time) override;

void WakeFromSuspendForHeartbeat(bool wake) override;

- InstanceIDHandler* GetInstanceIDHandler() override;

+ InstanceIDHandler* GetInstanceIDHandlerInternal() override;

void AddHeartbeatInterval(const std::string& scope, int interval_ms) override;

void RemoveHeartbeatInterval(const std::string& scope) override;

« no previous file with comments | « no previous file | components/gcm_driver/fake_gcm_driver.cc » ('j') | components/gcm_driver/instance_id/instance_id.h » ('J')