Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Side by Side Diff: components/gcm_driver/gcm_driver_desktop.cc

Issue 1785613006: Make GCMDriver::GetInstanceIDHandler protected, to avoid misuse (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address peter's nits Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/gcm_driver/gcm_driver_desktop.h" 5 #include "components/gcm_driver/gcm_driver_desktop.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/bind_helpers.h" 10 #include "base/bind_helpers.h"
(...skipping 802 matching lines...) Expand 10 before | Expand all | Expand 10 after
813 813
814 last_token_fetch_time_ = time; 814 last_token_fetch_time_ = time;
815 815
816 io_thread_->PostTask( 816 io_thread_->PostTask(
817 FROM_HERE, 817 FROM_HERE,
818 base::Bind(&GCMDriverDesktop::IOWorker::SetLastTokenFetchTime, 818 base::Bind(&GCMDriverDesktop::IOWorker::SetLastTokenFetchTime,
819 base::Unretained(io_worker_.get()), 819 base::Unretained(io_worker_.get()),
820 time)); 820 time));
821 } 821 }
822 822
823 InstanceIDHandler* GCMDriverDesktop::GetInstanceIDHandler() { 823 InstanceIDHandler* GCMDriverDesktop::GetInstanceIDHandlerInternal() {
824 return this; 824 return this;
825 } 825 }
826 826
827 void GCMDriverDesktop::GetToken( 827 void GCMDriverDesktop::GetToken(
828 const std::string& app_id, 828 const std::string& app_id,
829 const std::string& authorized_entity, 829 const std::string& authorized_entity,
830 const std::string& scope, 830 const std::string& scope,
831 const std::map<std::string, std::string>& options, 831 const std::map<std::string, std::string>& options,
832 const GetTokenCallback& callback) { 832 const GetTokenCallback& callback) {
833 DCHECK(!app_id.empty()); 833 DCHECK(!app_id.empty());
(...skipping 488 matching lines...) Expand 10 before | Expand all | Expand 10 after
1322 1322
1323 if (std::get<1>(a) < std::get<1>(b)) 1323 if (std::get<1>(a) < std::get<1>(b))
1324 return true; 1324 return true;
1325 if (std::get<1>(a) > std::get<1>(b)) 1325 if (std::get<1>(a) > std::get<1>(b))
1326 return false; 1326 return false;
1327 1327
1328 return std::get<2>(a) < std::get<2>(b); 1328 return std::get<2>(a) < std::get<2>(b);
1329 } 1329 }
1330 1330
1331 } // namespace gcm 1331 } // namespace gcm
OLDNEW
« no previous file with comments | « components/gcm_driver/gcm_driver_desktop.h ('k') | components/gcm_driver/gcm_driver_desktop_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698