Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Side by Side Diff: components/gcm_driver/gcm_driver_android.h

Issue 1785613006: Make GCMDriver::GetInstanceIDHandler protected, to avoid misuse (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address peter's nits Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/gcm_driver/gcm_driver.h ('k') | components/gcm_driver/gcm_driver_android.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_GCM_DRIVER_GCM_DRIVER_ANDROID_H 5 #ifndef COMPONENTS_GCM_DRIVER_GCM_DRIVER_ANDROID_H
6 #define COMPONENTS_GCM_DRIVER_GCM_DRIVER_ANDROID_H 6 #define COMPONENTS_GCM_DRIVER_GCM_DRIVER_ANDROID_H
7 7
8 #include <jni.h> 8 #include <jni.h>
9 9
10 #include "base/android/scoped_java_ref.h" 10 #include "base/android/scoped_java_ref.h"
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 ClearActivityLogs clear_logs) override; 67 ClearActivityLogs clear_logs) override;
68 void SetGCMRecording(const GetGCMStatisticsCallback& callback, 68 void SetGCMRecording(const GetGCMStatisticsCallback& callback,
69 bool recording) override; 69 bool recording) override;
70 void SetAccountTokens( 70 void SetAccountTokens(
71 const std::vector<GCMClient::AccountTokenInfo>& account_tokens) override; 71 const std::vector<GCMClient::AccountTokenInfo>& account_tokens) override;
72 void UpdateAccountMapping(const AccountMapping& account_mapping) override; 72 void UpdateAccountMapping(const AccountMapping& account_mapping) override;
73 void RemoveAccountMapping(const std::string& account_id) override; 73 void RemoveAccountMapping(const std::string& account_id) override;
74 base::Time GetLastTokenFetchTime() override; 74 base::Time GetLastTokenFetchTime() override;
75 void SetLastTokenFetchTime(const base::Time& time) override; 75 void SetLastTokenFetchTime(const base::Time& time) override;
76 void WakeFromSuspendForHeartbeat(bool wake) override; 76 void WakeFromSuspendForHeartbeat(bool wake) override;
77 InstanceIDHandler* GetInstanceIDHandler() override; 77 InstanceIDHandler* GetInstanceIDHandlerInternal() override;
78 void AddHeartbeatInterval(const std::string& scope, int interval_ms) override; 78 void AddHeartbeatInterval(const std::string& scope, int interval_ms) override;
79 void RemoveHeartbeatInterval(const std::string& scope) override; 79 void RemoveHeartbeatInterval(const std::string& scope) override;
80 80
81 // GCMStatsRecorder::Delegate implementation: 81 // GCMStatsRecorder::Delegate implementation:
82 void OnActivityRecorded() override; 82 void OnActivityRecorded() override;
83 83
84 protected: 84 protected:
85 // GCMDriver implementation: 85 // GCMDriver implementation:
86 GCMClient::Result EnsureStarted(GCMClient::StartMode start_mode) override; 86 GCMClient::Result EnsureStarted(GCMClient::StartMode start_mode) override;
87 void RegisterImpl(const std::string& app_id, 87 void RegisterImpl(const std::string& app_id,
(...skipping 16 matching lines...) Expand all
104 104
105 // Recorder that logs GCM activities. 105 // Recorder that logs GCM activities.
106 GCMStatsRecorderAndroid recorder_; 106 GCMStatsRecorderAndroid recorder_;
107 107
108 DISALLOW_COPY_AND_ASSIGN(GCMDriverAndroid); 108 DISALLOW_COPY_AND_ASSIGN(GCMDriverAndroid);
109 }; 109 };
110 110
111 } // namespace gcm 111 } // namespace gcm
112 112
113 #endif // COMPONENTS_GCM_DRIVER_GCM_DRIVER_ANDROID_H 113 #endif // COMPONENTS_GCM_DRIVER_GCM_DRIVER_ANDROID_H
OLDNEW
« no previous file with comments | « components/gcm_driver/gcm_driver.h ('k') | components/gcm_driver/gcm_driver_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698