Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: net/quic/crypto/crypto_server_test.cc

Issue 1785613005: Deprecate FLAG_require_strike_register_or_server_nonce (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@115890504
Patch Set: Deleted flag definition Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/quic/crypto/quic_crypto_server_config.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/crypto/crypto_server_test.cc
diff --git a/net/quic/crypto/crypto_server_test.cc b/net/quic/crypto/crypto_server_test.cc
index 4a65f874ab8c8daf23ae6c6bbd98ae18481b8158..85cf2aa8ae12b77c157edc5b90197d857706ee3c 100644
--- a/net/quic/crypto/crypto_server_test.cc
+++ b/net/quic/crypto/crypto_server_test.cc
@@ -726,50 +726,7 @@ TEST_P(CryptoServerTest, CorruptMultipleTags) {
};
}
-TEST_P(CryptoServerTest, ReplayProtection) {
- if (client_version_ > QUIC_VERSION_30) {
- return;
- }
- FLAGS_require_strike_register_or_server_nonce = false;
- // This tests that disabling replay protection works.
- // clang-format off
- CryptoHandshakeMessage msg = CryptoTestUtils::Message(
- "CHLO",
- "AEAD", "AESG",
- "KEXS", "C255",
- "SCID", scid_hex_.c_str(),
- "#004b5453", srct_hex_.c_str(),
- "PUBS", pub_hex_.c_str(),
- "NONC", nonce_hex_.c_str(),
- "XLCT", XlctHexString().c_str(),
- "VER\0", client_version_string_.c_str(),
- "$padding", static_cast<int>(kClientHelloMinimumSize),
- nullptr);
- // clang-format on
- ShouldSucceed(msg);
- // The message should be rejected because the strike-register is still
- // quiescent.
- CheckRejectTag();
-
- const HandshakeFailureReason kRejectReasons[] = {
- CLIENT_NONCE_INVALID_TIME_FAILURE};
- CheckRejectReasons(kRejectReasons, arraysize(kRejectReasons));
-
- config_.set_replay_protection(false);
-
- ShouldSucceed(msg);
- // The message should be accepted now.
- ASSERT_EQ(kSHLO, out_.tag());
- CheckServerHello(out_);
-
- ShouldSucceed(msg);
- // The message should accepted twice when replay protection is off.
- ASSERT_EQ(kSHLO, out_.tag());
- CheckServerHello(out_);
-}
-
TEST_P(CryptoServerTest, NoServerNonce) {
- FLAGS_require_strike_register_or_server_nonce = true;
// When no server nonce is present and no strike register is configured,
// the CHLO should be rejected.
// clang-format off
« no previous file with comments | « no previous file | net/quic/crypto/quic_crypto_server_config.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698