Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1256)

Unified Diff: chrome/browser/ui/views/frame/opaque_browser_frame_view.cc

Issue 1785613004: Dynamically compute tab/frame separator color. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review comments Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/opaque_browser_frame_view.cc
diff --git a/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc b/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc
index 53e69df1d366abeb7dfb64743978d2278e1e1999..13dd289705c67087ade64893fe4037775b1e0fd2 100644
--- a/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc
+++ b/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc
@@ -747,6 +747,8 @@ void OpaqueBrowserFrameView::PaintClientEdge(gfx::Canvas* canvas) const {
// MD the client edge images start at the top of the toolbar.
y += md ? toolbar_bounds.y() : toolbar_bounds.bottom();
} else {
+ // Note that windows without tabstrips are never themed, so we always use
+ // the default colors in this section.
toolbar_color = ThemeProperties::GetDefaultColor(
ThemeProperties::COLOR_TOOLBAR, incognito);
@@ -757,7 +759,9 @@ void OpaqueBrowserFrameView::PaintClientEdge(gfx::Canvas* canvas) const {
// Shadow.
BrowserView::Paint1pxHorizontalLine(
- canvas, tp->GetColor(ThemeProperties::COLOR_TOOLBAR_TOP_SEPARATOR),
+ canvas,
+ ThemeProperties::GetDefaultColor(
+ ThemeProperties::COLOR_TOOLBAR_TOP_SEPARATOR, incognito),
client_bounds, true);
} else {
// Ensure the client edge rects are drawn to the top of the location bar.

Powered by Google App Engine
This is Rietveld 408576698