Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1927)

Unified Diff: chrome/browser/ui/views/tabs/tab_strip.cc

Issue 1785613004: Dynamically compute tab/frame separator color. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/tabs/tab_strip.cc
diff --git a/chrome/browser/ui/views/tabs/tab_strip.cc b/chrome/browser/ui/views/tabs/tab_strip.cc
index 3729b49d6615be69ac12bbbed382ebaf83343654..237d90e69037b3916a1b5ee76d1934d44cdb544b 100644
--- a/chrome/browser/ui/views/tabs/tab_strip.cc
+++ b/chrome/browser/ui/views/tabs/tab_strip.cc
@@ -418,10 +418,15 @@ void NewTabButton::OnPaint(gfx::Canvas* canvas) {
paint.setAntiAlias(true);
const SkColor stroke_color =
tp->GetColor(ThemeProperties::COLOR_TOOLBAR_TOP_SEPARATOR);
+ const float alpha = SkColorGetA(stroke_color);
+ const SkAlpha shadow_alpha =
+ base::saturated_cast<SkAlpha>(std::round(2.1875f * alpha));
skia::RefPtr<SkDrawLooper> stroke_looper =
- CreateShadowDrawLooper(SkColorSetA(stroke_color, 0x8C));
+ CreateShadowDrawLooper(SkColorSetA(stroke_color, shadow_alpha));
paint.setLooper(stroke_looper.get());
- paint.setColor(SkColorSetA(stroke_color, pressed ? 0x38 : 0x27));
+ const SkAlpha path_alpha = static_cast<SkAlpha>(
+ std::round((pressed ? 0.875f : 0.609375f) * alpha));
+ paint.setColor(SkColorSetA(stroke_color, path_alpha));
canvas->DrawPath(stroke, paint);
} else {
// Fill.
@@ -567,8 +572,10 @@ void NewTabButton::PaintFill(bool pressed,
}
const SkColor stroke_color = GetThemeProvider()->GetColor(
ThemeProperties::COLOR_TOOLBAR_TOP_SEPARATOR);
+ const SkAlpha alpha = static_cast<SkAlpha>(
+ std::round(SkColorGetA(stroke_color) * 0.59375f));
skia::RefPtr<SkDrawLooper> looper =
- CreateShadowDrawLooper(SkColorSetA(stroke_color, 0x26));
+ CreateShadowDrawLooper(SkColorSetA(stroke_color, alpha));
paint.setLooper(looper.get());
canvas->DrawPath(fill, paint);
}
« chrome/browser/themes/theme_service.cc ('K') | « chrome/browser/themes/theme_service.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698