third_party/WebKit/Source/core/html/HTMLTextFormControlElement.h - Issue 1785603002: TEXTAREA: Cutting last line without EOL should not remove the remaining EOL in the previous line.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLTextFormControlElement.h

Issue 1785603002: TEXTAREA: Cutting last line without EOL should not remove the remaining EOL in the previous line. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove an ASSERT, update a comment Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp ('k') | third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLTextFormControlElement.h

diff --git a/third_party/WebKit/Source/core/html/HTMLTextFormControlElement.h b/third_party/WebKit/Source/core/html/HTMLTextFormControlElement.h

index e032959d5118748620fe4b4a51c7934849edce3b..38627890a34d7efa5b26e61d383059c973ede08e 100644

--- a/third_party/WebKit/Source/core/html/HTMLTextFormControlElement.h

+++ b/third_party/WebKit/Source/core/html/HTMLTextFormControlElement.h

@@ -97,6 +97,7 @@ public:

bool lastChangeWasUserEdit() const;

virtual void setInnerEditorValue(const String&);

String innerEditorValue() const;

+ PassRefPtrWillBeRawPtr<Node> createPlaceholderBreakElement() const;

String directionForFormData() const;

@@ -131,7 +132,7 @@ protected:

virtual void subtreeHasChanged() = 0;

void setLastChangeWasNotUserEdit() { m_lastChangeWasUserEdit = false; }

+ void addPlaceholderBreakElementIfNecessary();

String valueWithHardLineBreaks() const;

virtual bool shouldDispatchFormControlChangeEvent(String&, String&);