Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: experimental/PdfViewer/autogen/SkPdfMarkupAnnotationsDictionary_autogen.h

Issue 17856004: refactoring for pdf viewer lib (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: experimental/PdfViewer/autogen/SkPdfMarkupAnnotationsDictionary_autogen.h
===================================================================
--- experimental/PdfViewer/autogen/SkPdfMarkupAnnotationsDictionary_autogen.h (revision 9765)
+++ experimental/PdfViewer/autogen/SkPdfMarkupAnnotationsDictionary_autogen.h (working copy)
@@ -533,13 +533,7 @@
return (ObjectFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "Subtype", "", NULL));
}
- std::string Subtype() const {
- std::string ret;
- if (NameFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "Subtype", "", &ret)) return ret;
- // TODO(edisonn): warn about missing required field, assert for known good pdfs
- return "";
- }
-
+ std::string Subtype() const;
/** (Required) The text to be displayed in the pop-up window when the annota-
* tion is opened. Carriage returns may be used to separate the text into para-
* graphs.
@@ -548,13 +542,7 @@
return (ObjectFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "Contents", "", NULL));
}
- std::string Contents() const {
- std::string ret;
- if (StringFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "Contents", "", &ret)) return ret;
- // TODO(edisonn): warn about missing required field, assert for known good pdfs
- return "";
- }
-
+ std::string Contents() const;
/** (Required) An array of 8 x n numbers specifying the coordinates of n quadri-
* laterals in default user space. Each quadrilateral encompasses a word or
* group of contiguous words in the text underlying the annotation. The coor-
@@ -579,13 +567,7 @@
return (ObjectFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "QuadPoints", "", NULL));
}
- SkPdfArray* QuadPoints() const {
- SkPdfArray* ret;
- if (ArrayFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "QuadPoints", "", &ret)) return ret;
- // TODO(edisonn): warn about missing required field, assert for known good pdfs
- return NULL;
- }
-
+ SkPdfArray* QuadPoints() const;
};
#endif // __DEFINED__SkPdfMarkupAnnotationsDictionary

Powered by Google App Engine
This is Rietveld 408576698