Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: experimental/PdfViewer/autogen/SkPdfSeparationDictionary_autogen.h

Issue 17856004: refactoring for pdf viewer lib (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: experimental/PdfViewer/autogen/SkPdfSeparationDictionary_autogen.h
===================================================================
--- experimental/PdfViewer/autogen/SkPdfSeparationDictionary_autogen.h (revision 9765)
+++ experimental/PdfViewer/autogen/SkPdfSeparationDictionary_autogen.h (working copy)
@@ -535,13 +535,7 @@
return (ObjectFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "Pages", "", NULL));
}
- SkPdfArray* Pages() const {
- SkPdfArray* ret;
- if (ArrayFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "Pages", "", &ret)) return ret;
- // TODO(edisonn): warn about missing required field, assert for known good pdfs
- return NULL;
- }
-
+ SkPdfArray* Pages() const;
/** (Required) The name of the device colorant to be used in rendering this
* separation, such as Cyan or PANTONE 35 CV.
**/
@@ -555,26 +549,14 @@
return ret->podofo()->GetDataType() == ePdfDataType_Name;
}
- std::string getDeviceColorantAsName() const {
- std::string ret = "";
- if (NameFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "DeviceColorant", "", &ret)) return ret;
- // TODO(edisonn): warn about missing required field, assert for known good pdfs
- return "";
- }
-
+ std::string getDeviceColorantAsName() const;
bool isDeviceColorantAString() const {
SkPdfObject* ret = NULL;
if (!ObjectFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "DeviceColorant", "", &ret)) return false;
return ret->podofo()->GetDataType() == ePdfDataType_String || ret->podofo()->GetDataType() == ePdfDataType_HexString;
}
- std::string getDeviceColorantAsString() const {
- std::string ret = "";
- if (StringFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "DeviceColorant", "", &ret)) return ret;
- // TODO(edisonn): warn about missing required field, assert for known good pdfs
- return "";
- }
-
+ std::string getDeviceColorantAsString() const;
/** (Optional) An array defining a Separation or DeviceN color space (see "Separa-
* tion Color Spaces" on page 201 and "DeviceN Color Spaces" on page 205). This
* provides additional information about the color specified by DeviceColorant-
@@ -590,13 +572,7 @@
return (ObjectFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "ColorSpace", "", NULL));
}
- SkPdfArray* ColorSpace() const {
- SkPdfArray* ret;
- if (ArrayFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "ColorSpace", "", &ret)) return ret;
- // TODO(edisonn): warn about missing required field, assert for known good pdfs
- return NULL;
- }
-
+ SkPdfArray* ColorSpace() const;
};
#endif // __DEFINED__SkPdfSeparationDictionary

Powered by Google App Engine
This is Rietveld 408576698