Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2843)

Unified Diff: experimental/PdfViewer/autogen/SkPdfLaunchActionDictionary_autogen.h

Issue 17856004: refactoring for pdf viewer lib (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: experimental/PdfViewer/autogen/SkPdfLaunchActionDictionary_autogen.h
===================================================================
--- experimental/PdfViewer/autogen/SkPdfLaunchActionDictionary_autogen.h (revision 9765)
+++ experimental/PdfViewer/autogen/SkPdfLaunchActionDictionary_autogen.h (working copy)
@@ -532,13 +532,7 @@
return (ObjectFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "S", "", NULL));
}
- std::string S() const {
- std::string ret;
- if (NameFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "S", "", &ret)) return ret;
- // TODO(edisonn): warn about missing required field, assert for known good pdfs
- return "";
- }
-
+ std::string S() const;
/** (Required if none of the entries Win, Mac, or Unix is present) The application to
* be launched or the document to be opened or printed. If this entry is absent
* and the viewer application does not understand any of the alternative entries,
@@ -548,13 +542,7 @@
return (ObjectFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "F", "", NULL));
}
- SkPdfFileSpec F() const {
- SkPdfFileSpec ret;
- if (FileSpecFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "F", "", &ret)) return ret;
- // TODO(edisonn): warn about missing required field, assert for known good pdfs
- return SkPdfFileSpec();
- }
-
+ SkPdfFileSpec F() const;
/** (Optional) A dictionary containing Windows-specific launch parameters (see
* the Table 8.38; see also implementation note 73 in Appendix H).
**/
@@ -562,39 +550,21 @@
return (ObjectFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "Win", "", NULL));
}
- SkPdfDictionary* Win() const {
- SkPdfDictionary* ret;
- if (DictionaryFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "Win", "", &ret)) return ret;
- // TODO(edisonn): warn about missing required field, assert for known good pdfs
- return NULL;
- }
-
+ SkPdfDictionary* Win() const;
/** (Optional) Mac OS'specific launch parameters; not yet defined.
**/
bool has_Mac() const {
return (ObjectFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "Mac", "", NULL));
}
- SkPdfObject* Mac() const {
- SkPdfObject* ret;
- if (ObjectFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "Mac", "", &ret)) return ret;
- // TODO(edisonn): warn about missing required field, assert for known good pdfs
- return NULL;
- }
-
+ SkPdfObject* Mac() const;
/** (Optional) UNIX-specific launch parameters; not yet defined.
**/
bool has_Unix() const {
return (ObjectFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "Unix", "", NULL));
}
- SkPdfObject* Unix() const {
- SkPdfObject* ret;
- if (ObjectFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "Unix", "", &ret)) return ret;
- // TODO(edisonn): warn about missing required field, assert for known good pdfs
- return NULL;
- }
-
+ SkPdfObject* Unix() const;
/** (Optional; PDF 1.2) A flag specifying whether to open the destination docu-
* ment in a new window. If this flag is false, the destination document will
* replace the current document in the same window. If this entry is absent, the
@@ -606,13 +576,7 @@
return (ObjectFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "NewWindow", "", NULL));
}
- bool NewWindow() const {
- bool ret;
- if (BoolFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "NewWindow", "", &ret)) return ret;
- // TODO(edisonn): warn about missing required field, assert for known good pdfs
- return false;
- }
-
+ bool NewWindow() const;
};
#endif // __DEFINED__SkPdfLaunchActionDictionary

Powered by Google App Engine
This is Rietveld 408576698