Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2911)

Unified Diff: experimental/PdfViewer/autogen/SkPdfEmbeddedFileParameterDictionary_autogen.h

Issue 17856004: refactoring for pdf viewer lib (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: experimental/PdfViewer/autogen/SkPdfEmbeddedFileParameterDictionary_autogen.h
===================================================================
--- experimental/PdfViewer/autogen/SkPdfEmbeddedFileParameterDictionary_autogen.h (revision 9765)
+++ experimental/PdfViewer/autogen/SkPdfEmbeddedFileParameterDictionary_autogen.h (working copy)
@@ -531,39 +531,21 @@
return (ObjectFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "Size", "", NULL));
}
- long Size() const {
- long ret;
- if (LongFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "Size", "", &ret)) return ret;
- // TODO(edisonn): warn about missing required field, assert for known good pdfs
- return 0;
- }
-
+ long Size() const;
/** (Optional) The date and time when the embedded file was created.
**/
bool has_CreationDate() const {
return (ObjectFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "CreationDate", "", NULL));
}
- SkPdfDate CreationDate() const {
- SkPdfDate ret;
- if (DateFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "CreationDate", "", &ret)) return ret;
- // TODO(edisonn): warn about missing required field, assert for known good pdfs
- return SkPdfDate();
- }
-
+ SkPdfDate CreationDate() const;
/** (Optional) The date and time when the embedded file was last modified.
**/
bool has_ModDate() const {
return (ObjectFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "ModDate", "", NULL));
}
- SkPdfDate ModDate() const {
- SkPdfDate ret;
- if (DateFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "ModDate", "", &ret)) return ret;
- // TODO(edisonn): warn about missing required field, assert for known good pdfs
- return SkPdfDate();
- }
-
+ SkPdfDate ModDate() const;
/** (Optional) A subdictionary containing additional information specific to
* Mac OS files (see Table 3.35).
**/
@@ -571,13 +553,7 @@
return (ObjectFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "Mac", "", NULL));
}
- SkPdfDictionary* Mac() const {
- SkPdfDictionary* ret;
- if (DictionaryFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "Mac", "", &ret)) return ret;
- // TODO(edisonn): warn about missing required field, assert for known good pdfs
- return NULL;
- }
-
+ SkPdfDictionary* Mac() const;
/** (Optional) A 16-byte string that is the checksum of the bytes of the uncom-
* pressed embedded file. The checksum is calculated by applying the standard
* MD5 message-digest algorithm (described in Internet RFC 1321, The MD5
@@ -588,13 +564,7 @@
return (ObjectFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "CheckSum", "", NULL));
}
- std::string CheckSum() const {
- std::string ret;
- if (StringFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "CheckSum", "", &ret)) return ret;
- // TODO(edisonn): warn about missing required field, assert for known good pdfs
- return "";
- }
-
+ std::string CheckSum() const;
};
#endif // __DEFINED__SkPdfEmbeddedFileParameterDictionary

Powered by Google App Engine
This is Rietveld 408576698