Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: experimental/PdfViewer/autogen/SkPdfWindowsLaunchActionDictionary_autogen.h

Issue 17856004: refactoring for pdf viewer lib (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: experimental/PdfViewer/autogen/SkPdfWindowsLaunchActionDictionary_autogen.h
===================================================================
--- experimental/PdfViewer/autogen/SkPdfWindowsLaunchActionDictionary_autogen.h (revision 9765)
+++ experimental/PdfViewer/autogen/SkPdfWindowsLaunchActionDictionary_autogen.h (working copy)
@@ -535,26 +535,14 @@
return (ObjectFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "F", "", NULL));
}
- std::string F() const {
- std::string ret;
- if (StringFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "F", "", &ret)) return ret;
- // TODO(edisonn): warn about missing required field, assert for known good pdfs
- return "";
- }
-
+ std::string F() const;
/** (Optional) A string specifying the default directory in standard DOS syntax.
**/
bool has_D() const {
return (ObjectFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "D", "", NULL));
}
- std::string D() const {
- std::string ret;
- if (StringFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "D", "", &ret)) return ret;
- // TODO(edisonn): warn about missing required field, assert for known good pdfs
- return "";
- }
-
+ std::string D() const;
/** (Optional) A string specifying the operation to perform:
* open Open a document.
* print Print a document.
@@ -565,13 +553,7 @@
return (ObjectFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "O", "", NULL));
}
- std::string O() const {
- std::string ret;
- if (StringFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "O", "", &ret)) return ret;
- // TODO(edisonn): warn about missing required field, assert for known good pdfs
- return "";
- }
-
+ std::string O() const;
/** (Optional) A parameter string to be passed to the application designated by
* the F entry. This entry should be omitted if F designates a document.
**/
@@ -579,13 +561,7 @@
return (ObjectFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "P", "", NULL));
}
- std::string P() const {
- std::string ret;
- if (StringFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "P", "", &ret)) return ret;
- // TODO(edisonn): warn about missing required field, assert for known good pdfs
- return "";
- }
-
+ std::string P() const;
};
#endif // __DEFINED__SkPdfWindowsLaunchActionDictionary

Powered by Google App Engine
This is Rietveld 408576698