Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: experimental/PdfViewer/autogen/SkPdfURIActionDictionary_autogen.h

Issue 17856004: refactoring for pdf viewer lib (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: experimental/PdfViewer/autogen/SkPdfURIActionDictionary_autogen.h
===================================================================
--- experimental/PdfViewer/autogen/SkPdfURIActionDictionary_autogen.h (revision 9765)
+++ experimental/PdfViewer/autogen/SkPdfURIActionDictionary_autogen.h (working copy)
@@ -532,26 +532,14 @@
return (ObjectFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "S", "", NULL));
}
- std::string S() const {
- std::string ret;
- if (NameFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "S", "", &ret)) return ret;
- // TODO(edisonn): warn about missing required field, assert for known good pdfs
- return "";
- }
-
+ std::string S() const;
/** (Required) The uniform resource identifier to resolve, encoded in 7-bit ASCII.
**/
bool has_URI() const {
return (ObjectFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "URI", "", NULL));
}
- std::string URI() const {
- std::string ret;
- if (StringFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "URI", "", &ret)) return ret;
- // TODO(edisonn): warn about missing required field, assert for known good pdfs
- return "";
- }
-
+ std::string URI() const;
/** (Optional) A flag specifying whether to track the mouse position when the URI is re-
* solved (see below). Default value: false.
* This entry applies only to actions triggered by the user's clicking an annotation; it is
@@ -562,13 +550,7 @@
return (ObjectFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "IsMap", "", NULL));
}
- bool IsMap() const {
- bool ret;
- if (BoolFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "IsMap", "", &ret)) return ret;
- // TODO(edisonn): warn about missing required field, assert for known good pdfs
- return false;
- }
-
+ bool IsMap() const;
};
#endif // __DEFINED__SkPdfURIActionDictionary

Powered by Google App Engine
This is Rietveld 408576698