Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Unified Diff: experimental/PdfViewer/autogen/SkPdfInlineLevelStructureElementsDictionary_autogen.h

Issue 17856004: refactoring for pdf viewer lib (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: experimental/PdfViewer/autogen/SkPdfInlineLevelStructureElementsDictionary_autogen.h
===================================================================
--- experimental/PdfViewer/autogen/SkPdfInlineLevelStructureElementsDictionary_autogen.h (revision 9765)
+++ experimental/PdfViewer/autogen/SkPdfInlineLevelStructureElementsDictionary_autogen.h (working copy)
@@ -547,26 +547,14 @@
return ret->podofo()->GetDataType() == ePdfDataType_Real || ret->podofo()->GetDataType() == ePdfDataType_Number;
}
- double getLineHeightAsNumber() const {
- double ret = 0;
- if (DoubleFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "LineHeight", "", &ret)) return ret;
- // TODO(edisonn): warn about missing required field, assert for known good pdfs
- return 0;
- }
-
+ double getLineHeightAsNumber() const;
bool isLineHeightAName() const {
SkPdfObject* ret = NULL;
if (!ObjectFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "LineHeight", "", &ret)) return false;
return ret->podofo()->GetDataType() == ePdfDataType_Name;
}
- std::string getLineHeightAsName() const {
- std::string ret = "";
- if (NameFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "LineHeight", "", &ret)) return ret;
- // TODO(edisonn): warn about missing required field, assert for known good pdfs
- return "";
- }
-
+ std::string getLineHeightAsName() const;
};
#endif // __DEFINED__SkPdfInlineLevelStructureElementsDictionary

Powered by Google App Engine
This is Rietveld 408576698