Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(945)

Unified Diff: experimental/PdfViewer/autogen/SkPdfObjectReferenceDictionary_autogen.h

Issue 17856004: refactoring for pdf viewer lib (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: experimental/PdfViewer/autogen/SkPdfObjectReferenceDictionary_autogen.h
===================================================================
--- experimental/PdfViewer/autogen/SkPdfObjectReferenceDictionary_autogen.h (revision 9765)
+++ experimental/PdfViewer/autogen/SkPdfObjectReferenceDictionary_autogen.h (working copy)
@@ -532,13 +532,7 @@
return (ObjectFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "Type", "", NULL));
}
- std::string Type() const {
- std::string ret;
- if (NameFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "Type", "", &ret)) return ret;
- // TODO(edisonn): warn about missing required field, assert for known good pdfs
- return "";
- }
-
+ std::string Type() const;
/** (Optional; must be an indirect reference) The page object representing the page on
* which the object is rendered. This entry overrides any Pg entry in the structure ele-
* ment containing the object reference; it is required if the structure element has no such
@@ -548,26 +542,14 @@
return (ObjectFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "Pg", "", NULL));
}
- SkPdfDictionary* Pg() const {
- SkPdfDictionary* ret;
- if (DictionaryFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "Pg", "", &ret)) return ret;
- // TODO(edisonn): warn about missing required field, assert for known good pdfs
- return NULL;
- }
-
+ SkPdfDictionary* Pg() const;
/** (Required; must be an indirect reference) The referenced object.
**/
bool has_Obj() const {
return (ObjectFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "Obj", "", NULL));
}
- SkPdfObject* Obj() const {
- SkPdfObject* ret;
- if (ObjectFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "Obj", "", &ret)) return ret;
- // TODO(edisonn): warn about missing required field, assert for known good pdfs
- return NULL;
- }
-
+ SkPdfObject* Obj() const;
};
#endif // __DEFINED__SkPdfObjectReferenceDictionary

Powered by Google App Engine
This is Rietveld 408576698