refactoring for pdf viewer lib

experimental/PdfViewer/autogen/SkPdfJavascriptDictionary_autogen.h

 #ifndef __DEFINED__SkPdfJavascriptDictionary
 #define __DEFINED__SkPdfJavascriptDictionary
 
 #include "SkPdfUtils.h"
 #include "SkPdfEnums_autogen.h"
 #include "SkPdfArray_autogen.h"
 #include "SkPdfDictionary_autogen.h"
 
 // Entries in the JavaScript dictionary
 class SkPdfJavascriptDictionary : public SkPdfDictionary {
@@ skipping 520 matching lines @@
   bool has_Before() const {
     return (ObjectFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "Before", "", NULL));
   }
 
   bool isBeforeAString() const {
     SkPdfObject* ret = NULL;
     if (!ObjectFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "Before", "", &ret)) return false;
     return ret->podofo()->GetDataType() == ePdfDataType_String || ret->podofo()->GetDataType() == ePdfDataType_HexString;
   }
 
-  std::string getBeforeAsString() const {
-    std::string ret = "";
-    if (StringFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "Before", "", &ret)) return ret;
-    // TODO(edisonn): warn about missing required field, assert for known good pdfs
-    return "";
-  }
-
+  std::string getBeforeAsString() const;
   bool isBeforeAStream() const {
     SkPdfObject* ret = NULL;
     if (!ObjectFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "Before", "", &ret)) return false;
     return ret->podofo()->HasStream();
   }
 
-  SkPdfStream* getBeforeAsStream() const {
-    SkPdfStream* ret = NULL;
-    if (StreamFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "Before", "", &ret)) return ret;
-    // TODO(edisonn): warn about missing required field, assert for known good pdfs
-    return NULL;
-  }
-
+  SkPdfStream* getBeforeAsStream() const;
 /** (Optional) A string or stream containing a JavaScript script to be executed
  *  just after the FDF file is imported.
 **/
   bool has_After() const {
     return (ObjectFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "After", "", NULL));
   }
 
   bool isAfterAString() const {
     SkPdfObject* ret = NULL;
     if (!ObjectFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "After", "", &ret)) return false;
     return ret->podofo()->GetDataType() == ePdfDataType_String || ret->podofo()->GetDataType() == ePdfDataType_HexString;
   }
 
-  std::string getAfterAsString() const {
-    std::string ret = "";
-    if (StringFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "After", "", &ret)) return ret;
-    // TODO(edisonn): warn about missing required field, assert for known good pdfs
-    return "";
-  }
-
+  std::string getAfterAsString() const;
   bool isAfterAStream() const {
     SkPdfObject* ret = NULL;
     if (!ObjectFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "After", "", &ret)) return false;
     return ret->podofo()->HasStream();
   }
 
-  SkPdfStream* getAfterAsStream() const {
-    SkPdfStream* ret = NULL;
-    if (StreamFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "After", "", &ret)) return ret;
-    // TODO(edisonn): warn about missing required field, assert for known good pdfs
-    return NULL;
-  }
-
+  SkPdfStream* getAfterAsStream() const;
 /** (Optional) An array defining additional JavaScript scripts to be added to
  *  those defined in the JavaScript entry of the document's name dictionary (see
  *  Section 3.6.3, "Name Dictionary"). The array contains an even number of
  *  elements, organized in pairs. The first element of each pair is a name and the
  *  second is a string or stream defining the script corresponding to that name.
  *  Each of the defined scripts will be added to those already defined in the name
  *  dictionary and then executed before the script defined in the Before entry is
  *  executed. As described in "JavaScript Actions" on page 556, these scripts are
  *  used to define JavaScript functions for use by other scripts in the document.
 **/
   bool has_Doc() const {
     return (ObjectFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "Doc", "", NULL));
   }
 
-  SkPdfArray* Doc() const {
-    SkPdfArray* ret;
-    if (ArrayFromDictionary(fPodofoDoc, fPodofoObj->GetDictionary(), "Doc", "", &ret)) return ret;
-    // TODO(edisonn): warn about missing required field, assert for known good pdfs
-    return NULL;
-  }
-
+  SkPdfArray* Doc() const;
 };
 
 #endif  // __DEFINED__SkPdfJavascriptDictionary