Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(657)

Issue 1785593002: X87: [turbofan] [deoptimizer] Support inlining of ES6 tail calls. (Closed)

Created:
4 years, 9 months ago by zhengxing.li
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [turbofan] [deoptimizer] Support inlining of ES6 tail calls. port c29a4560bb548fa0ebeec8262f9d6fca9d50fe7a(r34610) original commit message: In case when F was called with incompatible number of arguments (and therefore the arguments adator frame was created), F inlines a tail call of G which then deopts the deoptimizer should also remove the arguments adaptor frame for F. This CL adds required machinery to the deoptimizer. BUG= Committed: https://crrev.com/7b84d299eaa9d843327eb6da5d5685bc55952ae6 Cr-Commit-Position: refs/heads/master@{#34651}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/x87/deoptimizer-x87.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 9 months ago (2016-03-10 02:47:26 UTC) #2
Weiliang
lgtm
4 years, 9 months ago (2016-03-10 03:53:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1785593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1785593002/1
4 years, 9 months ago (2016-03-10 05:53:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-10 06:14:24 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 06:15:55 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7b84d299eaa9d843327eb6da5d5685bc55952ae6
Cr-Commit-Position: refs/heads/master@{#34651}

Powered by Google App Engine
This is Rietveld 408576698