Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: tools/clang/rewrite_to_chrome_style/tests/methods-original.cc

Issue 1785563002: rewrite_to_chrome_style: Consistently decide if things are in blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rewrite-asserts: review Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/clang/rewrite_to_chrome_style/tests/methods-expected.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/rewrite_to_chrome_style/tests/methods-original.cc
diff --git a/tools/clang/rewrite_to_chrome_style/tests/methods-original.cc b/tools/clang/rewrite_to_chrome_style/tests/methods-original.cc
index 040582dd79f524c57e8c3c552ad09a6058612b0a..12165b7ad788fcb05f1e2009d5e57fd1f7ee344c 100644
--- a/tools/clang/rewrite_to_chrome_style/tests/methods-original.cc
+++ b/tools/clang/rewrite_to_chrome_style/tests/methods-original.cc
@@ -2,6 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+#include "gen/thing.h"
+
namespace v8 {
class InterfaceOutsideOfBlink {
@@ -97,6 +99,25 @@ class Testable {
int m_ptr;
};
+namespace subname {
+
+class SubnameParent {
+ virtual void subnameMethod() {}
+};
+
+} // namespace subname
+
+class SubnameChild : public subname::SubnameParent {
+ // This subclasses from blink::subname::SubnameParent and should be renamed.
+ void subnameMethod() override {}
+};
+
+class GenChild : public blink::GenClass {
+ // This subclasses from the blink namespace but in the gen directory so it
+ // should not be renamed.
+ void genMethod() override {}
+};
+
} // namespace blink
// Test that overrides from outside the Blink namespace are also updated.
« no previous file with comments | « tools/clang/rewrite_to_chrome_style/tests/methods-expected.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698