Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2136)

Unified Diff: tools/clang/plugins/tests/ipc.cpp

Issue 1785523002: Fix tests for check-ipc Clang plugin to pass on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adjust error counts Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/clang/plugins/tests/ipc.flags » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/plugins/tests/ipc.cpp
diff --git a/tools/clang/plugins/tests/ipc.cpp b/tools/clang/plugins/tests/ipc.cpp
index 0347e1cf2160e5422591f772e316d8e509208af3..d2bcef1d58d85e552c1dbaf00a7336edac14a10b 100644
--- a/tools/clang/plugins/tests/ipc.cpp
+++ b/tools/clang/plugins/tests/ipc.cpp
@@ -202,7 +202,7 @@ IPC_TEST_MESSAGE(__COUNTER__, (char, short, std::pair<size_t, bool>)) // ERROR
IPC_TEST_MESSAGE(__COUNTER__, (std::vector<std::vector<long&>&>&)) // ERROR
-/* Check IPC::WriteParam() arguments. ERRORS: 31 */
+/* Check IPC::WriteParam() arguments. ERRORS: 30 */
// ERRORS: 21
void TestWriteParamArgument() {
@@ -305,7 +305,7 @@ struct Provider {
std::vector<uint64_t> uint64s_data;
};
-// ERRORS: 10
+// ERRORS: 9
void TestWriteParamMemberArgument() {
Provider p;
@@ -325,7 +325,9 @@ void TestWriteParamMemberArgument() {
IPC::WriteParam(nullptr, p.get_long()); // ERROR
IPC::WriteParam(nullptr, p.long_data); // ERROR
- IPC::WriteParam(nullptr, p.get<size_t>()); // ERROR
+ // This one is flaky and depends on whether size_t is typedefed to a
+ // blacklisted type (unsigned long).
+ //IPC::WriteParam(nullptr, p.get<size_t>()); // ERROR
IPC::WriteParam(nullptr, p.get_size()); // ERROR
IPC::WriteParam(nullptr, p.size_data); // ERROR
@@ -348,4 +350,4 @@ void TestWriteParamMemberArgument() {
}
-/* ERRORS: 42 */
+/* ERRORS: 41 */
« no previous file with comments | « no previous file | tools/clang/plugins/tests/ipc.flags » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698