Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 1785503002: PPC: [undetectable] Really get comparisons of document.all right now. (Closed)

Created:
4 years, 9 months ago by MTBrandyberry
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [undetectable] Really get comparisons of document.all right now. Port 679d9503cffe631cb3b938627274aea10893069c Original commit message: According to https://www.w3.org/TR/html5/obsolete.html#dom-document-all, comparisons of document.all to other values such as strings or objects, are unaffected. In fact document.all only gets special treatment in comparisons with null or undefined according to HTML. Especially setting the undetectable doesn't make two distinct JSReceivers equal. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/eaa38ad1774a95fe0391b277e2497cf98a296b9c Cr-Commit-Position: refs/heads/master@{#34645}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3 lines) Patch
M src/ppc/code-stubs-ppc.cc View 3 chunks +14 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
MTBrandyberry
PTAL
4 years, 9 months ago (2016-03-09 22:37:09 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1785503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1785503002/1
4 years, 9 months ago (2016-03-09 22:37:25 UTC) #3
JoranSiu
On 2016/03/09 22:37:25, commit-bot: I haz the power wrote: > Dry run: CQ is trying ...
4 years, 9 months ago (2016-03-09 22:42:41 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-09 23:08:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1785503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1785503002/1
4 years, 9 months ago (2016-03-09 23:10:58 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-09 23:12:58 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 23:14:32 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eaa38ad1774a95fe0391b277e2497cf98a296b9c
Cr-Commit-Position: refs/heads/master@{#34645}

Powered by Google App Engine
This is Rietveld 408576698