[sqlite] sql::Recovery working under USE_SYSTEM_SQLITE.

[sqlite] sql::Recovery working under USE_SYSTEM_SQLITE.

Removes the USE_SYSTEM_SQLITE conditional sections in sql::Recover
implementation and tests.  third_party/sqlite includes sqlite_recover
library for the USE_SYSTEM_SQLITE case, with recover.c compiled against
the system version of SQLite.

Additionally remove interiorCursorEOF() from recover.c, as it was
unused, rather than adding a compile flag to allow it.

[Relands https://codereview.chromium.org/1782633002/ which
relanded https://codereview.chromium.org/1757653002/ ]

BUG=584407
TBR=sdefresne@chromium.org

Committed: https://crrev.com/b9606f86f7058774ba846c8f9cc8735deb251f0c
Cr-Commit-Position: refs/heads/master@{#380703}

[Scott Hess - ex-Googler, 2016-03-10 18:12:47]

Put sqlite_recover in is_ios for gn, also.

[Scott Hess - ex-Googler, 2016-03-10 18:14:50]

https://codereview.chromium.org/1785443004/diff/20001/third_party/sqlite/BUIL...
File third_party/sqlite/BUILD.gn (right):

https://codereview.chromium.org/1785443004/diff/20001/third_party/sqlite/BUIL...
third_party/sqlite/BUILD.gn:228: ":sqlite_recover",
This change was obviously suggested from the sqlite.gyp difference, but AFAICT
it didn't actually matter because gn calculated differences correctly. 
Unfortunately trybots and commit-queue don't consider gn on ios, apparently, and
I had only tested gn on Linux where I couldn't get use_system_sqlite to work. 
So...

[Scott Hess - ex-Googler, 2016-03-10 18:50:36]

sqlite_recover to public_deps for recovery.cc to include.

[Scott Hess - ex-Googler, 2016-03-10 19:24:19]

Comment out unused constants.

[Scott Hess - ex-Googler, 2016-03-10 20:15:30]

The CQ bit was checked by shess@chromium.org

[commit-bot: I haz the power, 2016-03-10 20:15:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1785443004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1785443004/60001

[commit-bot: I haz the power, 2016-03-10 21:03:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-10 21:03:27]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Scott Hess - ex-Googler, 2016-03-10 21:23:07]

The CQ bit was checked by shess@chromium.org

[commit-bot: I haz the power, 2016-03-10 21:23:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1785443004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1785443004/60001

[commit-bot: I haz the power, 2016-03-10 22:00:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-10 22:00:55]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Scott Hess - ex-Googler, 2016-03-10 22:17:37]

On 2016/03/10 22:00:55, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

crbug.com/593891 apparently.

[Scott Hess - ex-Googler, 2016-03-10 22:17:47]

The CQ bit was checked by shess@chromium.org

[commit-bot: I haz the power, 2016-03-10 22:18:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1785443004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1785443004/60001

[commit-bot: I haz the power, 2016-03-10 23:00:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-10 23:00:37]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Scott Hess - ex-Googler, 2016-03-10 23:38:02]

The CQ bit was checked by shess@chromium.org

[commit-bot: I haz the power, 2016-03-10 23:39:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1785443004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1785443004/60001

[commit-bot: I haz the power, 2016-03-11 00:17:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-11 00:17:09]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Scott Hess - ex-Googler, 2016-03-11 18:52:13]

The CQ bit was checked by shess@chromium.org

[commit-bot: I haz the power, 2016-03-11 18:52:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1785443004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1785443004/60001

[commit-bot: I haz the power, 2016-03-11 19:38:56]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-03-11 19:41:45]

Description was changed from

==========
[sqlite] sql::Recovery working under USE_SYSTEM_SQLITE.

Removes the USE_SYSTEM_SQLITE conditional sections in sql::Recover
implementation and tests.  third_party/sqlite includes sqlite_recover
library for the USE_SYSTEM_SQLITE case, with recover.c compiled against
the system version of SQLite.

Additionally remove interiorCursorEOF() from recover.c, as it was
unused, rather than adding a compile flag to allow it.

[Relands https://codereview.chromium.org/1782633002/ which
relanded https://codereview.chromium.org/1757653002/ ]

BUG=584407
TBR=sdefresne@chromium.org
==========

to

==========
[sqlite] sql::Recovery working under USE_SYSTEM_SQLITE.

Removes the USE_SYSTEM_SQLITE conditional sections in sql::Recover
implementation and tests.  third_party/sqlite includes sqlite_recover
library for the USE_SYSTEM_SQLITE case, with recover.c compiled against
the system version of SQLite.

Additionally remove interiorCursorEOF() from recover.c, as it was
unused, rather than adding a compile flag to allow it.

[Relands https://codereview.chromium.org/1782633002/ which
relanded https://codereview.chromium.org/1757653002/ ]

BUG=584407
TBR=sdefresne@chromium.org

Committed: https://crrev.com/b9606f86f7058774ba846c8f9cc8735deb251f0c
Cr-Commit-Position: refs/heads/master@{#380703}
==========

[commit-bot: I haz the power, 2016-03-11 19:41:46]

Patchset 4 (id:??) landed as
https://crrev.com/b9606f86f7058774ba846c8f9cc8735deb251f0c
Cr-Commit-Position: refs/heads/master@{#380703}