Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 178543011: Remove Version Check when Determining if Blacklist is Enabled (Closed)

Created:
6 years, 9 months ago by csharp
Modified:
6 years, 9 months ago
Reviewers:
robertshield, sky
CC:
chromium-reviews, caitkp+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Remove Version Check when Determining if Blacklist is Enabled If the registry says the blacklist is enabled, then enable it, even if it was enabled for a different version of Chrome. BUG=329023 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254819

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -65 lines) Patch
M chrome/browser/chrome_elf_init_win.cc View 2 chunks +28 lines, -35 lines 0 comments Download
M chrome_elf/blacklist.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome_elf/blacklist/blacklist.cc View 2 chunks +0 lines, -18 lines 0 comments Download
M chrome_elf/blacklist/test/blacklist_test.cc View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
csharp
6 years, 9 months ago (2014-03-03 21:55:02 UTC) #1
robertshield
Please add a bug number to the description. Code LGTM.
6 years, 9 months ago (2014-03-04 02:30:32 UTC) #2
csharp
Bug ID added
6 years, 9 months ago (2014-03-04 13:30:07 UTC) #3
csharp
sky@ for chrome/browser/chrome_elf_init_win.cc owner's approval
6 years, 9 months ago (2014-03-04 13:30:37 UTC) #4
sky
LGTM Can you also update chrome/browser/OWNERS for chrome/browser/chrome_elf_init_win.cc?
6 years, 9 months ago (2014-03-04 17:01:59 UTC) #5
csharp
The CQ bit was checked by csharp@chromium.org
6 years, 9 months ago (2014-03-04 18:46:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/csharp@chromium.org/178543011/1
6 years, 9 months ago (2014-03-04 18:49:12 UTC) #7
commit-bot: I haz the power
6 years, 9 months ago (2014-03-04 21:01:40 UTC) #8
Message was sent while issue was closed.
Change committed as 254819

Powered by Google App Engine
This is Rietveld 408576698