Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 178543008: Remove SVGCSSParser.cpp (Closed)

Created:
6 years, 9 months ago by rwlbuis
Modified:
6 years, 9 months ago
Reviewers:
pdr.
CC:
blink-reviews, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove SVGCSSParser.cpp This should have been removed in https://codereview.chromium.org/184693003/ Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168365

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -430 lines) Patch
Source/core/css/SVGCSSParser.cpp View 1 chunk +0 lines, -430 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
rwlbuis
easy rubber stamp kind of patch...
6 years, 9 months ago (2014-03-03 17:59:09 UTC) #1
pdr.
On 2014/03/03 17:59:09, rwlbuis wrote: > easy rubber stamp kind of patch... LGTM (reviewed via ...
6 years, 9 months ago (2014-03-03 18:52:44 UTC) #2
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 9 months ago (2014-03-03 18:52:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/178543008/1
6 years, 9 months ago (2014-03-03 18:53:02 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-03 20:04:37 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_layout for step(s) webkit_lint http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout&number=24799
6 years, 9 months ago (2014-03-03 20:04:39 UTC) #6
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 9 months ago (2014-03-03 20:05:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/178543008/1
6 years, 9 months ago (2014-03-03 20:05:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/178543008/1
6 years, 9 months ago (2014-03-03 23:20:20 UTC) #9
rwlbuis
The CQ bit was unchecked by rob.buis@samsung.com
6 years, 9 months ago (2014-03-04 02:12:16 UTC) #10
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 9 months ago (2014-03-04 02:12:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/178543008/1
6 years, 9 months ago (2014-03-04 02:12:36 UTC) #12
commit-bot: I haz the power
6 years, 9 months ago (2014-03-04 06:46:40 UTC) #13
Message was sent while issue was closed. 
Change committed as 168365

Powered by Google App Engine
This is Rietveld 408576698