Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 178543006: Move Document code out of Node.cpp (Closed)

Created:
6 years, 9 months ago by Inactive
Modified:
6 years, 9 months ago
Reviewers:
adamk, eseidel
CC:
blink-reviews, sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, rwlbuis
Visibility:
Public.

Description

Move Document code out of Node.cpp Move Document code out of Node.cpp and into Document.cpp for clarity. There is no reason (e.g. inlining) requiring that this code be in Node.cpp. R=adamk@chromium.org, adamk, eseidel Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168421

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -34 lines) Patch
M Source/core/dom/Document.cpp View 1 2 1 chunk +34 lines, -0 lines 0 comments Download
M Source/core/dom/Node.cpp View 1 2 1 chunk +0 lines, -34 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
Inactive
6 years, 9 months ago (2014-03-03 15:02:32 UTC) #1
adamk
lgtm
6 years, 9 months ago (2014-03-03 16:38:00 UTC) #2
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 9 months ago (2014-03-03 17:02:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/178543006/1
6 years, 9 months ago (2014-03-03 17:02:43 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-03 20:03:45 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_layout for step(s) webkit_lint http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout&number=24790
6 years, 9 months ago (2014-03-03 20:03:45 UTC) #6
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 9 months ago (2014-03-03 20:17:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/178543006/1
6 years, 9 months ago (2014-03-03 20:18:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/178543006/1
6 years, 9 months ago (2014-03-03 23:20:28 UTC) #9
Inactive
The CQ bit was unchecked by ch.dumez@samsung.com
6 years, 9 months ago (2014-03-04 04:19:36 UTC) #10
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 9 months ago (2014-03-04 04:19:46 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-04 13:47:29 UTC) #12
commit-bot: I haz the power
Retried try job too often on win_layout for step(s) webkit_lint http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout&number=25421
6 years, 9 months ago (2014-03-04 13:47:30 UTC) #13
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 9 months ago (2014-03-04 14:05:06 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/178543006/20001
6 years, 9 months ago (2014-03-04 14:05:17 UTC) #15
Inactive
6 years, 9 months ago (2014-03-05 03:04:05 UTC) #16
Message was sent while issue was closed. 
Committed patchset #3 manually as r168421 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698