[runtime] split up loops with HandleScopes

src/debug/debug-scopes.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/debug/debug-scopes.h"
 
 #include "src/ast/scopes.h"
 #include "src/debug/debug.h"
 #include "src/frames-inl.h"
 #include "src/globals.h"
@@ skipping 625 matching lines @@
   // Optimized frames are not supported.
   if (frame->is_optimized()) return false;
 
   Handle<JSFunction> function(frame->function());
   Handle<SharedFunctionInfo> shared(function->shared());
   Handle<ScopeInfo> scope_info(shared->scope_info());
 
   bool default_result = false;
 
   // Parameters.
-  for (int i = 0; i < scope_info->ParameterCount(); ++i) {
-    HandleScope scope(isolate_);
-    if (String::Equals(handle(scope_info->ParameterName(i)), variable_name)) {
-      frame->SetParameterValue(i, *new_value);
-      // Argument might be shadowed in heap context, don't stop here.
-      default_result = true;
-    }
-  }
+  FOR_WITH_HANDLE_SCOPE(
+      isolate_, int, i = 0, i, i < scope_info->ParameterCount(), ++i, {
+        if (String::Equals(handle(scope_info->ParameterName(i)),
+                           variable_name)) {
+          frame->SetParameterValue(i, *new_value);
+          // Argument might be shadowed in heap context, don't stop here.
+          default_result = true;
+        }
+      });
 
   // Stack locals.
-  for (int i = 0; i < scope_info->StackLocalCount(); ++i) {
-    HandleScope scope(isolate_);
-    if (String::Equals(handle(scope_info->StackLocalName(i)), variable_name)) {
-      frame->SetExpression(scope_info->StackLocalIndex(i), *new_value);
-      return true;
-    }
-  }
+  FOR_WITH_HANDLE_SCOPE(
+      isolate_, int, i = 0, i, i < scope_info->StackLocalCount(), ++i, {
+        if (String::Equals(handle(scope_info->StackLocalName(i)),
+                           variable_name)) {
+          frame->SetExpression(scope_info->StackLocalIndex(i), *new_value);
+          return true;
+        }
+      });
 
   if (scope_info->HasContext()) {
     // Context locals.
     Handle<Context> frame_context(Context::cast(frame->context()));
     Handle<Context> function_context(frame_context->declaration_context());
     if (SetContextLocalValue(scope_info, function_context, variable_name,
                              new_value)) {
       return true;
     }
 
@@ skipping 19 matching lines @@
 
   return default_result;
 }
 
 
 bool ScopeIterator::SetBlockVariableValue(Handle<String> variable_name,
                                           Handle<Object> new_value) {
   Handle<ScopeInfo> scope_info = CurrentScopeInfo();
   JavaScriptFrame* frame = GetFrame();
 
-  for (int i = 0; i < scope_info->StackLocalCount(); ++i) {
-    HandleScope scope(isolate_);
-    if (String::Equals(handle(scope_info->StackLocalName(i)), variable_name)) {
-      frame->SetExpression(scope_info->StackLocalIndex(i), *new_value);
-      return true;
-    }
-  }
+  FOR_WITH_HANDLE_SCOPE(
+      isolate_, int, i = 0, i, i < scope_info->StackLocalCount(), ++i, {
+        HandleScope scope(isolate_);
+        if (String::Equals(handle(scope_info->StackLocalName(i)),
+                           variable_name)) {
+          frame->SetExpression(scope_info->StackLocalIndex(i), *new_value);
+          return true;
+        }
+      });
 
   if (HasContext()) {
     Handle<Context> context = CurrentContext();
     if (SetContextLocalValue(scope_info, context, variable_name, new_value)) {
       return true;
     }
 
     Handle<JSObject> ext(context->extension_object(), isolate_);
     if (!ext.is_null()) {
       Maybe<bool> maybe = JSReceiver::HasOwnProperty(ext, variable_name);
@@ skipping 135 matching lines @@
     DCHECK(beg_pos >= 0 && end_pos >= 0);
     if (beg_pos <= position && position < end_pos) {
       GetNestedScopeChain(isolate, inner_scope, position);
       return;
     }
   }
 }
 
 }  // namespace internal
 }  // namespace v8