[runtime] split up loops with HandleScopes

src/d8.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 
 // Defined when linking against shared lib on Windows.
 #if defined(USING_V8_SHARED) && !defined(V8_SHARED)
 #define V8_SHARED
 #endif
 
@@ skipping 628 matching lines @@
 
 
 void Shell::Print(const v8::FunctionCallbackInfo<v8::Value>& args) {
   Write(args);
   printf("\n");
   fflush(stdout);
 }
 
 
 void Shell::Write(const v8::FunctionCallbackInfo<v8::Value>& args) {
-  for (int i = 0; i < args.Length(); i++) {
-    HandleScope handle_scope(args.GetIsolate());
-    if (i != 0) {
-      printf(" ");
-    }
+  FOR_WITH_HANDLE_SCOPE(
+      args.GetIsolate(), int, i = 0, i, i < args.Length(), i++, {
+        if (i != 0) {
+          printf(" ");
+        }
 
-    // Explicitly catch potential exceptions in toString().
-    v8::TryCatch try_catch(args.GetIsolate());
-    Local<Value> arg = args[i];
-    Local<String> str_obj;
+        // Explicitly catch potential exceptions in toString().
+        v8::TryCatch try_catch(args.GetIsolate());
+        Local<Value> arg = args[i];
+        Local<String> str_obj;
 
-    if (arg->IsSymbol()) {
-      arg = Local<Symbol>::Cast(arg)->Name();
-    }
-    if (!arg->ToString(args.GetIsolate()->GetCurrentContext())
-             .ToLocal(&str_obj)) {
-      try_catch.ReThrow();
-      return;
-    }
+        if (arg->IsSymbol()) {
+          arg = Local<Symbol>::Cast(arg)->Name();
+        }
+        if (!arg->ToString(args.GetIsolate()->GetCurrentContext())
+                 .ToLocal(&str_obj)) {
+          try_catch.ReThrow();
+          return;
+        }
 
-    v8::String::Utf8Value str(str_obj);
-    int n = static_cast<int>(fwrite(*str, sizeof(**str), str.length(), stdout));
-    if (n != str.length()) {
-      printf("Error in fwrite\n");
-      Exit(1);
-    }
-  }
+        v8::String::Utf8Value str(str_obj);
+        int n =
+            static_cast<int>(fwrite(*str, sizeof(**str), str.length(), stdout));
+        if (n != str.length()) {
+          printf("Error in fwrite\n");
+          Exit(1);
+        }
+      });
 }
 
 
 void Shell::Read(const v8::FunctionCallbackInfo<v8::Value>& args) {
   String::Utf8Value file(args[0]);
   if (*file == NULL) {
     Throw(args.GetIsolate(), "Error loading file");
     return;
   }
   Local<String> source = ReadFile(args.GetIsolate(), *file);
@@ skipping 36 matching lines @@
       return String::Concat(
           accumulator,
           String::NewFromUtf8(isolate, buffer, NewStringType::kNormal,
                               length - 1).ToLocalChecked());
     }
   }
 }
 
 
 void Shell::Load(const v8::FunctionCallbackInfo<v8::Value>& args) {
-  for (int i = 0; i < args.Length(); i++) {
-    HandleScope handle_scope(args.GetIsolate());
-    String::Utf8Value file(args[i]);
-    if (*file == NULL) {
-      Throw(args.GetIsolate(), "Error loading file");
-      return;
-    }
-    Local<String> source = ReadFile(args.GetIsolate(), *file);
-    if (source.IsEmpty()) {
-      Throw(args.GetIsolate(), "Error loading file");
-      return;
-    }
-    if (!ExecuteString(
-            args.GetIsolate(), source,
-            String::NewFromUtf8(args.GetIsolate(), *file,
-                                NewStringType::kNormal).ToLocalChecked(),
-            false, true)) {
-      Throw(args.GetIsolate(), "Error executing file");
-      return;
-    }
-  }
+  FOR_WITH_HANDLE_SCOPE(
+      args.GetIsolate(), int, i = 0, i, i < args.Length(), i++, {
+        String::Utf8Value file(args[i]);
+        if (*file == NULL) {
+          Throw(args.GetIsolate(), "Error loading file");
+          return;
+        }
+        Local<String> source = ReadFile(args.GetIsolate(), *file);
+        if (source.IsEmpty()) {
+          Throw(args.GetIsolate(), "Error loading file");
+          return;
+        }
+        if (!ExecuteString(args.GetIsolate(), source,
+                           String::NewFromUtf8(args.GetIsolate(), *file,
+                                               NewStringType::kNormal)
+                               .ToLocalChecked(),
+                           false, true)) {
+          Throw(args.GetIsolate(), "Error executing file");
+          return;
+        }
+      });
 }
 
 
 #ifndef V8_SHARED
 void Shell::WorkerNew(const v8::FunctionCallbackInfo<v8::Value>& args) {
   Isolate* isolate = args.GetIsolate();
   HandleScope handle_scope(isolate);
   if (args.Length() < 1 || !args[0]->IsString()) {
     Throw(args.GetIsolate(), "1st argument must be string");
     return;
@@ skipping 1777 matching lines @@
 }
 
 }  // namespace v8
 
 
 #ifndef GOOGLE3
 int main(int argc, char* argv[]) {
   return v8::Shell::Main(argc, argv);
 }
 #endif