Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 1785353002: Revert of Use std::unique_ptr. (Closed)

Created:
4 years, 9 months ago by mtklein
Modified:
4 years, 9 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Use std::unique_ptr. (patchset #8 id:130001 of https://codereview.chromium.org/1780933003/ ) Reason for revert: Another Android ambiguity due to implicit bool... frameworks/base/core/jni/android/graphics/Utils.cpp:110:35: error: call of overloaded 'SkMemoryStream(SkAutoTUnref<SkData>&)' is ambiguous return new SkMemoryStream(data); Original issue's description: > Use std::unique_ptr. > > TBR=reed@google.com > > Committed: https://skia.googlesource.com/skia/+/20c1e3abfc681771f73eb19fde7284196e028940 > > Committed: https://skia.googlesource.com/skia/+/3dd9ed37c24611af86f0fe374bd3698b63f09450 TBR=bungeman@google.com,mtklein@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/218c846ac0509f70d6da3eb3a439fa89b589f7b5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+529 lines, -81 lines) Patch
M gyp/core.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkRefCnt.h View 2 chunks +3 lines, -4 lines 0 comments Download
M include/gpu/gl/SkGLContext.h View 1 chunk +1 line, -1 line 0 comments Download
M include/private/SkOncePtr.h View 3 chunks +3 lines, -3 lines 0 comments Download
M include/private/SkTemplates.h View 4 chunks +13 lines, -13 lines 0 comments Download
A include/private/SkUniquePtr.h View 1 chunk +408 lines, -0 lines 0 comments Download
M src/core/SkAdvancedTypefaceMetrics.h View 3 chunks +3 lines, -32 lines 0 comments Download
M src/core/SkAdvancedTypefaceMetrics.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkGlyphCache.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkSharedMutex.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/GrLayerAtlas.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/text/GrStencilAndCoverTextContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/pdf/SkPDFDevice.h View 1 chunk +1 line, -1 line 0 comments Download
M src/pdf/SkPDFDevice.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ports/SkFontHost_FreeType.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/CPlusPlusEleven.cpp View 1 chunk +69 lines, -0 lines 0 comments Download
M tests/ClearTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/PictureTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ResourceCacheTest.cpp View 6 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
mtklein
Created Revert of Use std::unique_ptr.
4 years, 9 months ago (2016-03-11 14:10:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1785353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1785353002/1
4 years, 9 months ago (2016-03-11 14:10:23 UTC) #2
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 14:10:33 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/218c846ac0509f70d6da3eb3a439fa89b589f7b5

Powered by Google App Engine
This is Rietveld 408576698