Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 17853002: Create Web IDL watchlist and add myself to it (Closed)

Created:
7 years, 6 months ago by do-not-use
Modified:
7 years, 6 months ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, lgombos
Visibility:
Public.

Description

Create Web IDL watchlist and add myself to it Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153089

Patch Set 1 #

Total comments: 1

Patch Set 2 : Do not ignore testing and inspector IDLs #

Patch Set 3 : Rebase on master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M WATCHLISTS View 1 2 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
do-not-use
7 years, 6 months ago (2013-06-26 10:33:31 UTC) #1
haraken
LGTM
7 years, 6 months ago (2013-06-26 11:45:14 UTC) #2
haraken
https://codereview.chromium.org/17853002/diff/1/WATCHLISTS File WATCHLISTS (right): https://codereview.chromium.org/17853002/diff/1/WATCHLISTS#newcode150 WATCHLISTS:150: 'filepath': 'Source/core/(?!inspector)(?!testing).*\.idl' Why do you want to intentionally exclude ...
7 years, 6 months ago (2013-06-26 11:45:55 UTC) #3
do-not-use
On 2013/06/26 11:45:55, haraken wrote: > https://codereview.chromium.org/17853002/diff/1/WATCHLISTS > File WATCHLISTS (right): > > https://codereview.chromium.org/17853002/diff/1/WATCHLISTS#newcode150 > ...
7 years, 6 months ago (2013-06-26 11:48:35 UTC) #4
haraken
> I honestly imported the list from WebKit as it has worked OK for me ...
7 years, 6 months ago (2013-06-26 11:56:06 UTC) #5
do-not-use
On 2013/06/26 11:56:06, haraken wrote: > > I honestly imported the list from WebKit as ...
7 years, 6 months ago (2013-06-26 12:01:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/17853002/7001
7 years, 6 months ago (2013-06-26 12:01:33 UTC) #7
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=2380
7 years, 6 months ago (2013-06-26 12:12:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/17853002/12001
7 years, 6 months ago (2013-06-26 18:16:20 UTC) #9
commit-bot: I haz the power
7 years, 6 months ago (2013-06-26 20:13:15 UTC) #10
Message was sent while issue was closed.
Change committed as 153089

Powered by Google App Engine
This is Rietveld 408576698