[WebView] Reorganize all of the WebView Shell apks into their own dir.

[WebView] Reorganize all of the WebView Shell apks into their own dir.

Thought I could clean up the android_webview/tools dir a little bit.
It basically has some random tools as well as the WebViewShell apks
so I moved all the apks into a shared folder.

- Moved all WebViewShell Apks into tools/system_webview_shell
- Moved WebViewShell/test/ to system_webview_shell/test/data/ to better
match the naming of test data elsewhere
- Removed DEPRECATED_java_in_dir from tools/BUILD.gn.
- Updated gn_migration.gypi since GN targets exist for the WebView
Shell apks.

BUG=

Committed: https://crrev.com/49971fcb594aaa7181e001b3111cd3bf6410fb67
Cr-Commit-Position: refs/heads/master@{#382390}

[mikecase (-- gone --), 2016-03-11 21:15:05]

Description was changed from

==========
[WebView] Reorganize all of the WebView Shell apks into their own dir.

Thought I could clean up the android_webview/tools dir a little bit.
It basically has some random tools as well as the WebViewShell apks.

- Moved all WebViewShell Apks into tools/webview_shell
- Renamed WebViewShellTest to LayoutTests to make consistent with
naming in Blink
- Moved WebViewShell/test/ to webview_shell/test/data/ to better
match the naming of test data elsewhere
- Removed DEPRECATED_java_in_dir from tools/BUILD.gn.

BUG=
==========

to

==========
[WebView] Reorganize all of the WebView Shell apks into their own dir.

Thought I could clean up the android_webview/tools dir a little bit.
It basically has some random tools as well as the WebViewShell apks
so I moved all the apks into a shared folder.

- Moved all WebViewShell Apks into tools/webview_shell
- Renamed WebViewShellTest to LayoutTests to make consistent with
naming in Blink
- Moved WebViewShell/test/ to webview_shell/test/data/ to better
match the naming of test data elsewhere
- Removed DEPRECATED_java_in_dir from tools/BUILD.gn.
- Updated gn_migration.gypi since GN targets exist for the WebView 
Shell apks.

BUG=
==========

[mikecase (-- gone --), 2016-03-11 21:17:32]

mikecase@chromium.org changed reviewers:
+ sgurun@chromium.org, timvolodine@chromium.org, yolandyan@chromium.org

[mikecase (-- gone --), 2016-03-11 21:17:33]

I thought I could improve the organization of the WebView shell/test apks a
little bit.
Also updated some things in the build files. All of what I changed is listed in
the commit
description.

Tell me what you think and if you like or don't like this change. Since I didn't
change
any of the build target names that are used by the bots nothing will have to be
changed on
the infrastructure side.

thanks :D

[sgurun-gerrit only, 2016-03-12 02:38:24]

On 2016/03/11 21:17:33, mikecase wrote:
> I thought I could improve the organization of the WebView shell/test apks a
> little bit.
> Also updated some things in the build files. All of what I changed is listed
in
> the commit
> description.
> 
> Tell me what you think and if you like or don't like this change. Since I
didn't
> change
> any of the build target names that are used by the bots nothing will have to
be
> changed on
> the infrastructure side.
> 
> thanks :D

let's get Tim's opinion first, and I will look.

[timvolodine, 2016-03-14 19:36:38]

thanks Mike,

how about this structure though:

tools/system_webview_shell
       |--apk/
       |--layout_tests/
       |--page_cycler/
       |--test/data/

which looks more in line with chromium naming. Also, not sure if we really need
to keep it under tools/ but probably fine for now..

https://codereview.chromium.org/1785283005/diff/20001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/1785283005/diff/20001/BUILD.gn#newcode313
BUILD.gn:313: "//android_webview/tools/webview_shell",
why is this needed?

[mikecase (-- gone --), 2016-03-15 21:05:36]

Description was changed from

==========
[WebView] Reorganize all of the WebView Shell apks into their own dir.

Thought I could clean up the android_webview/tools dir a little bit.
It basically has some random tools as well as the WebViewShell apks
so I moved all the apks into a shared folder.

- Moved all WebViewShell Apks into tools/webview_shell
- Renamed WebViewShellTest to LayoutTests to make consistent with
naming in Blink
- Moved WebViewShell/test/ to webview_shell/test/data/ to better
match the naming of test data elsewhere
- Removed DEPRECATED_java_in_dir from tools/BUILD.gn.
- Updated gn_migration.gypi since GN targets exist for the WebView 
Shell apks.

BUG=
==========

to

==========
[WebView] Reorganize all of the WebView Shell apks into their own dir.

Thought I could clean up the android_webview/tools dir a little bit.
It basically has some random tools as well as the WebViewShell apks
so I moved all the apks into a shared folder.

- Moved all WebViewShell Apks into tools/system_webview_shell
- Moved WebViewShell/test/ to webview_shell/test/data/ to better
match the naming of test data elsewhere
- Removed DEPRECATED_java_in_dir from tools/BUILD.gn.
- Updated gn_migration.gypi since GN targets exist for the WebView 
Shell apks.

BUG=
==========

[mikecase (-- gone --), 2016-03-15 21:08:01]

Made the directory rename changes you suggested. Tested building all the
effected targets with GYP and GN.

https://codereview.chromium.org/1785283005/diff/20001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/1785283005/diff/20001/BUILD.gn#newcode313
BUILD.gn:313: "//android_webview/tools/webview_shell",
On 2016/03/14 at 19:36:38, timvolodine wrote:
> why is this needed?

This is needed because I moved the BUILD.gn file for the webview shell targets
from src/android_webview/tools to src/android_webview/tools/webview_shell (now
it is in src/android_webview/tools/system_webview_shell)

[timvolodine, 2016-03-18 17:50:00]

On 2016/03/15 21:08:01, mikecase wrote:
> Made the directory rename changes you suggested. Tested building all the
> effected targets with GYP and GN.
> 
> https://codereview.chromium.org/1785283005/diff/20001/BUILD.gn
> File BUILD.gn (right):
> 
> https://codereview.chromium.org/1785283005/diff/20001/BUILD.gn#newcode313
> BUILD.gn:313: "//android_webview/tools/webview_shell",
> On 2016/03/14 at 19:36:38, timvolodine wrote:
> > why is this needed?
> 
> This is needed because I moved the BUILD.gn file for the webview shell targets
> from src/android_webview/tools to src/android_webview/tools/webview_shell (now
> it is in src/android_webview/tools/system_webview_shell)

ok thanks lgtm.

Could you also add OWNERS file with my name in it to system_webview_shell/test/
please? Otherwise I can do it myself but would be easier if you could do it in
one go :)

[sgurun-gerrit only, 2016-03-18 18:16:02]

On 2016/03/18 17:50:00, timvolodine wrote:
> On 2016/03/15 21:08:01, mikecase wrote:
> > Made the directory rename changes you suggested. Tested building all the
> > effected targets with GYP and GN.
> > 
> > https://codereview.chromium.org/1785283005/diff/20001/BUILD.gn
> > File BUILD.gn (right):
> > 
> > https://codereview.chromium.org/1785283005/diff/20001/BUILD.gn#newcode313
> > BUILD.gn:313: "//android_webview/tools/webview_shell",
> > On 2016/03/14 at 19:36:38, timvolodine wrote:
> > > why is this needed?
> > 
> > This is needed because I moved the BUILD.gn file for the webview shell
targets
> > from src/android_webview/tools to src/android_webview/tools/webview_shell
(now
> > it is in src/android_webview/tools/system_webview_shell)
> 
> ok thanks lgtm.
> 
> Could you also add OWNERS file with my name in it to
system_webview_shell/test/
> please? Otherwise I can do it myself but would be easier if you could do it in
> one go :)

can you also update the description to be inline with your new patch. basically,
the test/data is now under system_webview_shell

[mikecase (-- gone --), 2016-03-18 19:25:29]

Description was changed from

==========
[WebView] Reorganize all of the WebView Shell apks into their own dir.

Thought I could clean up the android_webview/tools dir a little bit.
It basically has some random tools as well as the WebViewShell apks
so I moved all the apks into a shared folder.

- Moved all WebViewShell Apks into tools/system_webview_shell
- Moved WebViewShell/test/ to webview_shell/test/data/ to better
match the naming of test data elsewhere
- Removed DEPRECATED_java_in_dir from tools/BUILD.gn.
- Updated gn_migration.gypi since GN targets exist for the WebView 
Shell apks.

BUG=
==========

to

==========
[WebView] Reorganize all of the WebView Shell apks into their own dir.

Thought I could clean up the android_webview/tools dir a little bit.
It basically has some random tools as well as the WebViewShell apks
so I moved all the apks into a shared folder.

- Moved all WebViewShell Apks into tools/system_webview_shell
- Moved WebViewShell/test/ to system_webview_shell/test/data/ to better
match the naming of test data elsewhere
- Removed DEPRECATED_java_in_dir from tools/BUILD.gn.
- Updated gn_migration.gypi since GN targets exist for the WebView 
Shell apks.

BUG=
==========

[mikecase (-- gone --), 2016-03-18 20:35:29]

mikecase@chromium.org changed reviewers:
+ dpranke@chromium.org

[mikecase (-- gone --), 2016-03-18 20:35:30]

-Added OWNERS file for the system_webview_shell dir with tim's name.
-Updated CL description with correct test/data path

+ dpranke@chromium.org for review of BUILD.gn and build/gn_migration.gypi
Basically just updating one of the target names in BUILD.gn and updating
gn_migration due
to the fact that the webview shell test targets have GN build targets.

[Dirk Pranke, 2016-03-18 21:05:12]

lgtm

[sgurun-gerrit only, 2016-03-18 21:08:48]

lgtm

[mikecase (-- gone --), 2016-03-18 23:03:48]

The CQ bit was checked by mikecase@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-18 23:04:33]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1785283005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1785283005/60001

[commit-bot: I haz the power, 2016-03-18 23:18:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-18 23:18:13]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[mikecase (-- gone --), 2016-03-21 16:37:54]

mikecase@chromium.org changed reviewers:
+ yfriedman@chromium.org

[mikecase (-- gone --), 2016-03-21 16:37:55]

+ yfriedman@chromium.org for OWNER of content/public/test/android/javatests.

Need a reviewer for that it seems since I'm moving the file
android_webview/tools/PageCycler/DEPS
which has this dir in the includes_rules.

[Yaron, 2016-03-21 16:49:57]

lgtm

[mikecase (-- gone --), 2016-03-21 18:08:47]

The CQ bit was checked by mikecase@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-21 18:09:08]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1785283005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1785283005/60001

[commit-bot: I haz the power, 2016-03-21 19:18:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-21 19:18:49]

Dry run: This issue passed the CQ dry run.

[mikecase (-- gone --), 2016-03-21 21:10:29]

The CQ bit was checked by mikecase@chromium.org

[mikecase (-- gone --), 2016-03-21 21:10:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
timvolodine@chromium.org
Link to the patchset: https://codereview.chromium.org/1785283005/#ps60001
(title: " ")

[commit-bot: I haz the power, 2016-03-21 21:10:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1785283005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1785283005/60001

[commit-bot: I haz the power, 2016-03-21 21:18:14]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-03-21 21:19:13]

Description was changed from

==========
[WebView] Reorganize all of the WebView Shell apks into their own dir.

Thought I could clean up the android_webview/tools dir a little bit.
It basically has some random tools as well as the WebViewShell apks
so I moved all the apks into a shared folder.

- Moved all WebViewShell Apks into tools/system_webview_shell
- Moved WebViewShell/test/ to system_webview_shell/test/data/ to better
match the naming of test data elsewhere
- Removed DEPRECATED_java_in_dir from tools/BUILD.gn.
- Updated gn_migration.gypi since GN targets exist for the WebView 
Shell apks.

BUG=
==========

to

==========
[WebView] Reorganize all of the WebView Shell apks into their own dir.

Thought I could clean up the android_webview/tools dir a little bit.
It basically has some random tools as well as the WebViewShell apks
so I moved all the apks into a shared folder.

- Moved all WebViewShell Apks into tools/system_webview_shell
- Moved WebViewShell/test/ to system_webview_shell/test/data/ to better
match the naming of test data elsewhere
- Removed DEPRECATED_java_in_dir from tools/BUILD.gn.
- Updated gn_migration.gypi since GN targets exist for the WebView
Shell apks.

BUG=

Committed: https://crrev.com/49971fcb594aaa7181e001b3111cd3bf6410fb67
Cr-Commit-Position: refs/heads/master@{#382390}
==========

[commit-bot: I haz the power, 2016-03-21 21:19:15]

Patchset 4 (id:??) landed as
https://crrev.com/49971fcb594aaa7181e001b3111cd3bf6410fb67
Cr-Commit-Position: refs/heads/master@{#382390}