CREDENTIAL: Persist PasswordForm's primary key through CredentialInfo.

components/password_manager/core/common/credential_manager_types.h

Index: components/password_manager/core/common/credential_manager_types.h
diff --git a/components/password_manager/core/common/credential_manager_types.h b/components/password_manager/core/common/credential_manager_types.h
index f798acff8af7dfb837f7f2ff40760cf55135ed7e..f60b3e0e3d15141dea69eec6f592460a9a5bff43 100644
--- a/components/password_manager/core/common/credential_manager_types.h
+++ b/components/password_manager/core/common/credential_manager_types.h
@@ -58,6 +58,13 @@ struct CredentialInfo {
 
   // Corresponds to WebFederatedCredential's provider property.
   url::Origin federation;
+
+  // Oh, primary keys, how I love thee. We don't use any of this data except
+  // insofar as we need it to find the right PasswordForm to update if the
+  // form was originally saved through our heuristics.
+  base::string16 username_element;
+  base::string16 password_element;
+  std::string signon_realm;

[vasilii, 2016/03/11 14:29:48]

What if you just have autofill::PasswordForm or scoped_ptr<PasswordForm> here.
And copy it or some of its fields?
I have concerns that PasswordForm::origin may be different from what you pass
into CreatePasswordFormFromCredentialInfo.

 };
 
 // Create a new autofill::PasswordForm object based on |info|, valid in the