Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(737)

Issue 1785173005: Revert of Flip proprietary codecs to false for Android chromium builds. (Closed)

Created:
4 years, 9 months ago by pkotwicz
Modified:
4 years, 9 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Flip proprietary codecs to false for Android chromium builds. (patchset #11 id:220001 of https://codereview.chromium.org/1577433004/ ) Reason for revert: Broke AndroidWebViewTest. See https://build.chromium.org/p/chromium.linux/builders/Android%20GN Original issue's description: > Flip proprietary codecs to false for Android chromium builds. > > Official builds still using branding=Chrome so they will continue > to support codecs and containers like h264, mp3, aac, and mp4. > > Adds support for video/webm videos using vp8,vorbis to the webview > tests so they will continue to work w/o proprietary codecs. > > We have approval to do this now. Summary will be posted to the > src= launch bug: http://crbug.com/533190#c17 > > This will require some changes to the build flags for the official > WebView AOSP builders, which I'll land shortly after this. > > BUG=570762 > TEST=webview tests pass. > > Committed: https://crrev.com/43631fe1435e3c79467550b2cf797383d4cba8e6 > Cr-Commit-Position: refs/heads/master@{#380649} TBR=boliu@chromium.org,ddorwin@chromium.org,dpranke@chromium.org,nyquist@chromium.org,dalecurtis@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=570762 Committed: https://crrev.com/2ceccae6337cab6b6d5be02413c2b56ebaebca1b Cr-Commit-Position: refs/heads/master@{#380731}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -62 lines) Patch
M android_webview/android_webview_tests.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/KeySystemTest.java View 6 chunks +4 lines, -29 lines 0 comments Download
M android_webview/test/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/test/shell/assets/full_screen_video_inside_div_test.html View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/test/shell/assets/full_screen_video_test.html View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/test/shell/assets/multiple_videos_test.html View 1 chunk +2 lines, -2 lines 0 comments Download
A android_webview/test/shell/assets/video.mp4 View Binary file 0 comments Download
D android_webview/test/shell/assets/video.webm View Binary file 0 comments Download
M build/common.gypi View 1 chunk +4 lines, -3 lines 0 comments Download
M build/config/features.gni View 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/contextmenu/ContextMenuTest.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/android/contextmenu/context_menu_test.html View 1 chunk +1 line, -1 line 0 comments Download
D chrome/test/data/android/media/test.webm View Binary file 0 comments Download
M components/cdm/browser/widevine_drm_delegate_android.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M components/dom_distiller/content/browser/distiller_page_web_contents_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/test/data/dom_distiller/video_article.html View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/media_canplaytype_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/BUILD.gn View 1 chunk +6 lines, -2 lines 0 comments Download
M media/base/android/BUILD.gn View 2 chunks +1 line, -5 lines 0 comments Download
M media/base/mime_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/audio_decoder_unittest.cc View 3 chunks +7 lines, -1 line 0 comments Download
M media/media.gyp View 3 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
pkotwicz
Created Revert of Flip proprietary codecs to false for Android chromium builds.
4 years, 9 months ago (2016-03-11 21:13:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1785173005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1785173005/1
4 years, 9 months ago (2016-03-11 21:14:07 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-11 21:15:17 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2ceccae6337cab6b6d5be02413c2b56ebaebca1b Cr-Commit-Position: refs/heads/master@{#380731}
4 years, 9 months ago (2016-03-11 21:16:41 UTC) #5
Dirk Pranke
4 years, 9 months ago (2016-03-11 21:19:19 UTC) #6
Message was sent while issue was closed.
lgtm.

Powered by Google App Engine
This is Rietveld 408576698