Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 1785163002: Move the contents of initializeWithoutV8/shutdownWithoutV8 to Platform::initialize/shutdown (Closed)

Created:
4 years, 9 months ago by haraken
Modified:
4 years, 9 months ago
Reviewers:
sof
CC:
chromium-reviews, blink-reviews, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move the contents of initializeWithoutV8/shutdownWithoutV8 to Platform::initialize/shutdown Now that initializeWithoutV8/shutdownWithoutV8 doesn't have any dependency on core, modules and wtf, we can move the contents to Platform::initialize/shutdown. BUG=593269 Committed: https://crrev.com/daa2210782173ed9961d8eba2a5589f855e0c0fc Cr-Commit-Position: refs/heads/master@{#380592}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -92 lines) Patch
M third_party/WebKit/Source/platform/exported/Platform.cpp View 3 chunks +48 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/testing/RunAllTests.cpp View 1 2 2 chunks +22 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/web/WebKit.cpp View 5 chunks +4 lines, -68 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
haraken
PTAL
4 years, 9 months ago (2016-03-11 09:06:36 UTC) #2
sof
lgtm how would you now summarize what Platform::initialize() is responsible for doing?
4 years, 9 months ago (2016-03-11 09:27:56 UTC) #3
haraken
> how would you now summarize what Platform::initialize() is responsible for > doing? Platform::initialize => ...
4 years, 9 months ago (2016-03-11 09:29:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1785163002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1785163002/40001
4 years, 9 months ago (2016-03-11 09:30:06 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-11 10:28:59 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 10:30:04 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/daa2210782173ed9961d8eba2a5589f855e0c0fc
Cr-Commit-Position: refs/heads/master@{#380592}

Powered by Google App Engine
This is Rietveld 408576698