content/browser/renderer_host/render_view_host_impl.cc - Issue 1785153005: Remove SiteIsolationPolicy::IsSwappedOutStateForbidden().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_view_host_impl.cc

Issue 1785153005: Remove SiteIsolationPolicy::IsSwappedOutStateForbidden(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase on ToT. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/render_frame_host_manager_unittest.cc ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_view_host_impl.cc

diff --git a/content/browser/renderer_host/render_view_host_impl.cc b/content/browser/renderer_host/render_view_host_impl.cc

index 4a8e86b36ef797495dfc657c799570b1bfd82d86..173b4eda6757090736e4a38d275f82744a84106a 100644

--- a/content/browser/renderer_host/render_view_host_impl.cc

+++ b/content/browser/renderer_host/render_view_host_impl.cc

@@ -292,12 +292,11 @@ bool RenderViewHostImpl::CreateRenderView(

CHECK(main_frame_routing_id_ != MSG_ROUTING_NONE ||

proxy_route_id != MSG_ROUTING_NONE);

- // If swappedout:// is disabled, we should not set both main_frame_routing_id_

- // and proxy_route_id. Log cases that this happens (without crashing) to

- // track down https://crbug.com/574245.

+ // We should not set both main_frame_routing_id_ and proxy_route_id. Log

+ // cases that this happens (without crashing) to track down

+ // https://crbug.com/574245.

// TODO(creis): Remove this once we've found the cause.

- if (SiteIsolationPolicy::IsSwappedOutStateForbidden() &&

- main_frame_routing_id_ != MSG_ROUTING_NONE &&

+ if (main_frame_routing_id_ != MSG_ROUTING_NONE &&

proxy_route_id != MSG_ROUTING_NONE)

base::debug::DumpWithoutCrashing();