Made full screen video with DevTools not flash black on Android.

content/common/gpu/media/android_deferred_rendering_backing_strategy.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_COMMON_GPU_MEDIA_ANDROID_DEFERRED_RENDERING_BACKING_STRATEGY_H_
 #define CONTENT_COMMON_GPU_MEDIA_ANDROID_DEFERRED_RENDERING_BACKING_STRATEGY_H_
 
 #include <stdint.h>
 
 #include "base/macros.h"
 #include "content/common/content_export.h"
 #include "content/common/gpu/media/android_video_decode_accelerator.h"
+#include "ui/gl/gl_bindings.h"
 
 namespace gl {
 class GLImage;
 }
 
 namespace gpu {
 namespace gles2 {
 class GLStreamTextureImage;
 class TextureRef;
 }
@@ skipping 16 matching lines @@
   ~AndroidDeferredRenderingBackingStrategy() override;
 
   // AndroidVideoDecodeAccelerator::BackingStrategy
   gfx::ScopedJavaSurface Initialize(int surface_view_id) override;
   void Cleanup(bool have_context,
                const AndroidVideoDecodeAccelerator::OutputBufferMap&) override;
   scoped_refptr<gfx::SurfaceTexture> GetSurfaceTexture() const override;
   uint32_t GetTextureTarget() const override;
   void UseCodecBufferForPictureBuffer(int32_t codec_buffer_index,
                                       const media::PictureBuffer&) override;
-  void AssignOnePictureBuffer(const media::PictureBuffer&) override;
+  void AssignOnePictureBuffer(const media::PictureBuffer&, bool) override;
   void ReuseOnePictureBuffer(const media::PictureBuffer&) override;
   void DismissOnePictureBuffer(const media::PictureBuffer&) override;
   void CodecChanged(
       media::VideoCodecBridge*,
       const AndroidVideoDecodeAccelerator::OutputBufferMap&) override;
   void OnFrameAvailable() override;
   bool ArePicturesOverlayable() override;
   void UpdatePictureBufferSize(media::PictureBuffer* picture_buffer,
                                const gfx::Size& new_size) override;
 
@@ skipping 12 matching lines @@
   // picture buffer textures with it. The picture buffer textures will not
   // dependend on |this|, the SurfaceTexture, the MediaCodec or the VDA, so it's
   // used to back the picture buffers when the VDA is being destroyed.
   void CopySurfaceTextureToPictures(
       const AndroidVideoDecodeAccelerator::OutputBufferMap& buffers);
 
   // Return true if and only if the surface_texture_cant_detach workaround is
   // not set.
   bool DoesSurfaceTextureDetachWork() const;
 
+  // Create an EGLImage by creating a 2D texture, calling |init_texture| while
+  // it's bound, and then creating the EGLImage from that.  The caller takes
+  // ownership of the resulting EGLImage.
+  EGLImageKHR CreateImageFromTexture(bool (

[DaleCurtis, 2016/03/11 19:23:36]

Use callback instead?

[liberato (no reviews please), 2016/03/11 19:53:57]

since the strategy isn't refcounted, didn't seem to add anything.  i'll update
to base::Callback and see how it looks.

originally, i wanted to send in a lambda, but i couldn't get base::Bind to work
with it (even though i found a discussion on it that says it should).

+      AndroidDeferredRenderingBackingStrategy::*init_texture)(GLint source_id));
+
+  // Init |source_id| to be a copy of the current |surface_texture_| buffer.
+  // |source_id| is the service id of the 2D texture.
+  bool InitTextureWithCopy(GLint source_id);
+
+  // Init |source_id| to be a 1x1 transparent texture.
+  bool InitTransparentTexture(GLint source_id);
+
   scoped_refptr<AVDASharedState> shared_state_;
 
   AVDAStateProvider* state_provider_;
 
+  // EGLImage for a 1x1 transparent texture, or EGL_NO_IMAGE_KHR.
+  EGLImageKHR transparent_image_;
+
   // The SurfaceTexture to render to. Non-null after Initialize() if
   // we're not rendering to a SurfaceView.
   scoped_refptr<gfx::SurfaceTexture> surface_texture_;
 
   media::VideoCodecBridge* media_codec_;
 
   DISALLOW_COPY_AND_ASSIGN(AndroidDeferredRenderingBackingStrategy);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_COMMON_GPU_MEDIA_ANDROID_DEFERRED_RENDERING_BACKING_STRATEGY_H_