components/domain_reliability/monitor.cc - Issue 1785143003: [Domain Reliability: Monitor] Report beacon if the go away is detected, regardless of request statu…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/domain_reliability/monitor.cc

Issue 1785143003: [Domain Reliability: Monitor] Report beacon if the go away is detected, regardless of request statu… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: set sample rate to 1.0 if beacon is sent for receives goway for port migration Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/domain_reliability/context.cc ('K') | « components/domain_reliability/context_unittest.cc ('k') | components/domain_reliability/monitor_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/domain_reliability/monitor.cc

diff --git a/components/domain_reliability/monitor.cc b/components/domain_reliability/monitor.cc

index a8d87d44ee7b6ccba4e2a9069e5a2c6dce0c6b83..2fdafadcbd1c6f73380c033527949934fff2810e 100644

--- a/components/domain_reliability/monitor.cc

+++ b/components/domain_reliability/monitor.cc

@@ -294,6 +294,8 @@ bool DomainReliabilityMonitor::RequestInfo::ShouldReportRequest(

return true;

if (URLRequestStatusToNetError(request.status) != net::OK)

return true;

+ if (request.details.quic_port_migration_detected)

+ return true;

return false;

}