[Domain Reliability: Monitor] Report beacon if the go away is detected, regardless of request statu…

components/domain_reliability/context.cc

Index: components/domain_reliability/context.cc
diff --git a/components/domain_reliability/context.cc b/components/domain_reliability/context.cc
index 3dc324dd36f3d80baf008e988f48525ec69b1659..4d7c83e2008c1ba8899674f98edc559548cd5c1e 100644
--- a/components/domain_reliability/context.cc
+++ b/components/domain_reliability/context.cc
@@ -70,7 +70,9 @@ DomainReliabilityContext::~DomainReliabilityContext() {
 void DomainReliabilityContext::OnBeacon(
     scoped_ptr<DomainReliabilityBeacon> beacon) {
   bool success = (beacon->status == "ok");
-  double sample_rate = config().GetSampleRate(success);
+  double sample_rate = beacon->details.quic_port_migration_detected

[Deprecated (see juliatuttle), 2016/03/14 13:19:20]

nit: I'd prefer you do this with should_report, not sample_rate, since I think
it is clearer, but either is fine, especially as this is temporary debugging
code.

[Zhongyi Shi, 2016/03/14 17:12:42]

I think the idea here is that 1. we want to report whatever the request status
is, "should_report" should always be true. 2. the sample rate for this beacon is
1.0 as it only represents itself.

So setting sample_rate to 1.0 sounds more reasonable?

[Deprecated (see juliatuttle), 2016/03/14 17:18:35]

Oh, you're right, I forgot we were recording sample_rate below. Sounds good to
me.

+                           ? 1.0
+                           : config().GetSampleRate(success);
   bool should_report = base::RandDouble() < sample_rate;
   UMA_HISTOGRAM_BOOLEAN("DomainReliability.BeaconReported", should_report);
   if (!should_report) {