[Domain Reliability: Monitor] Report beacon if the go away is detected, regardless of request statu…

components/domain_reliability/context.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/domain_reliability/context.h"
 
 #include <algorithm>
 #include <utility>
 
 #include "base/bind.h"
@@ skipping 52 matching lines @@
       last_network_change_time_(last_network_change_time),
       weak_factory_(this) {}
 
 DomainReliabilityContext::~DomainReliabilityContext() {
   ClearBeacons();
 }
 
 void DomainReliabilityContext::OnBeacon(
     scoped_ptr<DomainReliabilityBeacon> beacon) {
   bool success = (beacon->status == "ok");
-  double sample_rate = config().GetSampleRate(success);
+  double sample_rate = beacon->details.quic_port_migration_detected

[Deprecated (see juliatuttle), 2016/03/14 13:19:20]

nit: I'd prefer you do this with should_report, not sample_rate, since I think
it is clearer, but either is fine, especially as this is temporary debugging
code.

[Zhongyi Shi, 2016/03/14 17:12:42]

I think the idea here is that 1. we want to report whatever the request status
is, "should_report" should always be true. 2. the sample rate for this beacon is
1.0 as it only represents itself.

So setting sample_rate to 1.0 sounds more reasonable?

[Deprecated (see juliatuttle), 2016/03/14 17:18:35]

Oh, you're right, I forgot we were recording sample_rate below. Sounds good to
me.

+                           ? 1.0
+                           : config().GetSampleRate(success);
   bool should_report = base::RandDouble() < sample_rate;
   UMA_HISTOGRAM_BOOLEAN("DomainReliability.BeaconReported", should_report);
   if (!should_report) {
     // If the beacon isn't queued to be reported, it definitely cannot evict
     // an older beacon. (This histogram is also logged below based on whether
     // an older beacon was actually evicted.)
     LogOnBeaconDidEvictHistogram(false);
     return;
   }
   beacon->sample_rate = sample_rate;
@@ skipping 164 matching lines @@
   delete beacons_.front();
   beacons_.pop_front();
 
   // If that just removed a beacon counted in uploading_beacons_size_, decrement
   // that.
   if (uploading_beacons_size_ > 0)
     --uploading_beacons_size_;
 }
 
 }  // namespace domain_reliability