Set default --lock_timeout to 5m

Set default --lock_timeout to 5m

gclient-sync + git-cache are racy because if two different DEPS files
dependent on the same repo URL, even if depsed to different checkout
dirs, they use same git cache dir. If both checkout dirs are synced at
the same time, one of them cannot acquire a lock.

This is a cheap solution to change --lock_timeout option default value
from 0 to 5m.

R=hinoka@chromium.org
BUG=593468
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299386

[nodir, 2016-03-12 00:56:29]

The CQ bit was checked by nodir@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-12 00:56:31]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1785083005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1785083005/1

[commit-bot: I haz the power, 2016-03-12 00:59:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-12 00:59:22]

Dry run: This issue passed the CQ dry run.

[nodir, 2016-03-12 01:01:58]

PTAL

[hinoka, 2016-03-14 09:38:19]

lgtm

https://codereview.chromium.org/1785083005/diff/1/git_cache.py
File git_cache.py (right):

https://codereview.chromium.org/1785083005/diff/1/git_cache.py#newcode96
git_cache.py:96: If self.timeout is zero, this is a NON-BLOCKING FAIL-FAST
operation.
Hm at some point this stopped being true... Probably want to remove this
comment.

[nodir, 2016-03-18 20:25:12]

https://codereview.chromium.org/1785083005/diff/1/git_cache.py
File git_cache.py (right):

https://codereview.chromium.org/1785083005/diff/1/git_cache.py#newcode96
git_cache.py:96: If self.timeout is zero, this is a NON-BLOCKING FAIL-FAST
operation.
On 2016/03/14 09:38:19, hinoka wrote:
> Hm at some point this stopped being true... Probably want to remove this
> comment.

Done.

[nodir, 2016-03-18 20:25:16]

The CQ bit was checked by nodir@chromium.org

[nodir, 2016-03-18 20:25:17]

The patchset sent to the CQ was uploaded after l-g-t-m from hinoka@chromium.org
Link to the patchset: https://codereview.chromium.org/1785083005/#ps20001
(title: "updated comment")

[commit-bot: I haz the power, 2016-03-18 20:25:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1785083005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1785083005/20001

[commit-bot: I haz the power, 2016-03-18 20:27:54]

Description was changed from

==========
Set default --lock_timeout to 5m

gclient-sync + git-cache are racy because if two different DEPS files
dependent on the same repo URL, even if depsed to different checkout
dirs, they use same git cache dir. If both checkout dirs are synced at
the same time, one of them cannot acquire a lock.

This is a cheap solution to change --lock_timeout option default value
from 0 to 5m.

R=hinoka@chromium.org
BUG=593468
==========

to

==========
Set default --lock_timeout to 5m

gclient-sync + git-cache are racy because if two different DEPS files
dependent on the same repo URL, even if depsed to different checkout
dirs, they use same git cache dir. If both checkout dirs are synced at
the same time, one of them cannot acquire a lock.

This is a cheap solution to change --lock_timeout option default value
from 0 to 5m.

R=hinoka@chromium.org
BUG=593468

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299386
==========

[commit-bot: I haz the power, 2016-03-18 20:27:55]

Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299386