Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 1785003004: Revert of Replace PushIfAbsent by a Stack object and move StringBuilderJoin to JS (Closed)

Created:
4 years, 9 months ago by Michael Achenbach
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Replace PushIfAbsent by a Stack object and move StringBuilderJoin to JS (patchset #6 id:100001 of https://codereview.chromium.org/1775403008/ ) Reason for revert: [Sheriff] This lets a gc stress test time out: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20gc%20stress/builds/2337/steps/Mjsunit%20%28flakes%29/logs/regress-542823 The test ran in <2sec before this. Please fix the test as well on a reland. Original issue's description: > Replace PushIfAbsent by a Stack object and move StringBuilderJoin to JS > > This significantly speeds up String(array). > BUG= > > Committed: https://crrev.com/c91faa0b39b62025460eb9f8b578e20d88f3549e > Cr-Commit-Position: refs/heads/master@{#34696} TBR=cbruni@chromium.org,adamk@chromium.org,bmeurer@chromium.org,verwaest@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/0ca38a6df876eb9737a2fcaa800fb3703dce09ff Cr-Commit-Position: refs/heads/master@{#34706}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -73 lines) Patch
M src/js/array.js View 6 chunks +8 lines, -49 lines 0 comments Download
M src/js/json.js View 7 chunks +6 lines, -16 lines 0 comments Download
M src/runtime/runtime.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/runtime/runtime-array.cc View 1 chunk +23 lines, -0 lines 0 comments Download
M src/runtime/runtime-strings.cc View 1 chunk +83 lines, -0 lines 0 comments Download
D test/mjsunit/json-stringify-stack.js View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of Replace PushIfAbsent by a Stack object and move StringBuilderJoin to JS
4 years, 9 months ago (2016-03-11 08:39:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1785003004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1785003004/1
4 years, 9 months ago (2016-03-11 08:39:54 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-11 08:40:05 UTC) #4
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 08:41:40 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0ca38a6df876eb9737a2fcaa800fb3703dce09ff
Cr-Commit-Position: refs/heads/master@{#34706}

Powered by Google App Engine
This is Rietveld 408576698