Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 17850002: Add dependency to ICU 4.6 (Closed)

Created:
7 years, 6 months ago by jochen (gone - plz use gerrit)
Modified:
7 years, 5 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Add dependency to ICU 4.6 We use the patched version from the chromium project, as it already has a gyp file and allows for using the system icu instead of the bundled version if desired. This is in preparation of bringing in v8-i18n. R=jkummerow@chromium.org BUG=v8:2745 Committed: http://code.google.com/p/v8/source/detail?r=15402

Patch Set 1 #

Patch Set 2 : updates #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+205 lines, -0 lines) Patch
M DEPS View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M Makefile View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M build/all.gyp View 1 chunk +3 lines, -0 lines 0 comments Download
A build/shim_headers.gypi View 1 2 1 chunk +73 lines, -0 lines 0 comments Download
M build/standalone.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A tools/generate_shim_headers/generate_shim_headers.py View 1 chunk +122 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jochen (gone - plz use gerrit)
I still need to patch the icu.gyp file, so this doesn't compile yet, however, the ...
7 years, 5 months ago (2013-06-27 11:24:13 UTC) #1
jochen (gone - plz use gerrit)
rebased. ptal.
7 years, 5 months ago (2013-06-29 19:40:40 UTC) #2
Jakob Kummerow
LGTM, I'll land.
7 years, 5 months ago (2013-07-01 07:51:38 UTC) #3
Jakob Kummerow
On second thought, let's skip the dependency on ICU in all.gyp for now. I'm making ...
7 years, 5 months ago (2013-07-01 08:32:07 UTC) #4
Jakob Kummerow
7 years, 5 months ago (2013-07-01 08:32:48 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r15402 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698