aura: Make Window::HitTest() a private method.

aura: Make Window::HitTest() a private method.

This is the first step towards removing Window::HitTest(), and related methods
from WindowDelegate (and corresponding methods in views::WidgetDelegate). This
is currently used only in a handful of places. This CL replaces those calls
with equivalent code, and makes Window::HitTest() a private method, so that
new code do not use it.

BUG=318879
R=sky@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253138

[sky, 2014-02-24 21:04:38]

https://codereview.chromium.org/178493003/diff/1/ash/wm/app_list_controller.cc
File ash/wm/app_list_controller.cc (right):

https://codereview.chromium.org/178493003/diff/1/ash/wm/app_list_controller.c...
ash/wm/app_list_controller.cc:313: aura::Window* window =
view_->GetWidget()->GetNativeView();
Is the coordinate system here right?

[sadrul, 2014-02-24 21:10:15]

https://codereview.chromium.org/178493003/diff/1/ash/wm/app_list_controller.cc
File ash/wm/app_list_controller.cc (right):

https://codereview.chromium.org/178493003/diff/1/ash/wm/app_list_controller.c...
ash/wm/app_list_controller.cc:313: aura::Window* window =
view_->GetWidget()->GetNativeView();
On 2014/02/24 21:04:38, sky wrote:
> Is the coordinate system here right?

The altered code doesn't actually deal with coordinates/locations. It simply
checks whether the target window is [inside] the window of the app-list bubble.

[sky, 2014-02-24 21:11:38]

LGTM

https://codereview.chromium.org/178493003/diff/1/ash/wm/app_list_controller.cc
File ash/wm/app_list_controller.cc (right):

https://codereview.chromium.org/178493003/diff/1/ash/wm/app_list_controller.c...
ash/wm/app_list_controller.cc:313: aura::Window* window =
view_->GetWidget()->GetNativeView();
On 2014/02/24 21:10:16, sadrul wrote:
> On 2014/02/24 21:04:38, sky wrote:
> > Is the coordinate system here right?
> 
> The altered code doesn't actually deal with coordinates/locations. It simply
> checks whether the target window is [inside] the window of the app-list
bubble.

Indeed. The old code was doing conversions though. But I see those end up in the
same thing. So, ok.

[sadrul, 2014-02-25 12:47:26]

Committed patchset #1 manually as r253138 (presubmit successful).