Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1784913004: bluetooth: Move StartNotifySession_Multiple adjacent to related tests. (Closed)

Created:
4 years, 9 months ago by scheib
Modified:
4 years, 9 months ago
Reviewers:
ortuno
CC:
chromium-reviews, ortuno+watch_chromium.org, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: Move StartNotifySession_Multiple adjacent to related tests. Improve bluetooth_gatt_characteristic_unittest.cc readability by keeping StartNotifySessions_ tests contiguous. R=ortuno@chromium.org Committed: https://crrev.com/c0449e880afd4175daddff4960ec12290618ed0e Cr-Commit-Position: refs/heads/master@{#381109}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -34 lines) Patch
M device/bluetooth/bluetooth_gatt_characteristic_unittest.cc View 1 2 chunks +34 lines, -34 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (5 generated)
scheib
4 years, 9 months ago (2016-03-11 03:31:39 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1784913004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1784913004/1
4 years, 9 months ago (2016-03-11 03:32:10 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/116224)
4 years, 9 months ago (2016-03-11 03:42:57 UTC) #5
ortuno
lgtm
4 years, 9 months ago (2016-03-14 18:18:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1784913004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1784913004/20001
4 years, 9 months ago (2016-03-14 22:19:14 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-14 23:25:22 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-14 23:27:09 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c0449e880afd4175daddff4960ec12290618ed0e
Cr-Commit-Position: refs/heads/master@{#381109}

Powered by Google App Engine
This is Rietveld 408576698