Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Unified Diff: net/quic/reliable_quic_stream.cc

Issue 1784903003: Remove FEC from send path. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@114770052
Patch Set: Restore accidentally removed OnRttChanged call Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/reliable_quic_stream.h ('k') | net/quic/reliable_quic_stream_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/reliable_quic_stream.cc
diff --git a/net/quic/reliable_quic_stream.cc b/net/quic/reliable_quic_stream.cc
index eea769d38f39fc40bb636e30183f718eefcfeb67..c4c7d5c9119c4538c547cfdd6096ee4c9b2298ab 100644
--- a/net/quic/reliable_quic_stream.cc
+++ b/net/quic/reliable_quic_stream.cc
@@ -66,7 +66,6 @@ ReliableQuicStream::ReliableQuicStream(QuicStreamId id, QuicSession* session)
fin_received_(false),
rst_sent_(false),
rst_received_(false),
- fec_policy_(FEC_PROTECT_OPTIONAL),
perspective_(session_->perspective()),
flow_controller_(session_->connection(),
id_,
@@ -81,11 +80,7 @@ ReliableQuicStream::ReliableQuicStream(QuicStreamId id, QuicSession* session)
ReliableQuicStream::~ReliableQuicStream() {}
-void ReliableQuicStream::SetFromConfig() {
- if (session_->config()->HasClientSentConnectionOption(kFSTR, perspective_)) {
- fec_policy_ = FEC_PROTECT_ALWAYS;
- }
-}
+void ReliableQuicStream::SetFromConfig() {}
void ReliableQuicStream::OnStreamFrame(const QuicStreamFrame& frame) {
DCHECK_EQ(frame.stream_id, id_);
@@ -311,9 +306,9 @@ QuicConsumedData ReliableQuicStream::WritevData(
write_length = static_cast<size_t>(send_window);
}
- QuicConsumedData consumed_data = session()->WritevData(
- id(), QuicIOVector(iov, iov_count, write_length), stream_bytes_written_,
- fin, GetFecProtection(), ack_listener);
+ QuicConsumedData consumed_data =
+ session()->WritevData(id(), QuicIOVector(iov, iov_count, write_length),
+ stream_bytes_written_, fin, ack_listener);
stream_bytes_written_ += consumed_data.bytes_consumed;
AddBytesSent(consumed_data.bytes_consumed);
@@ -343,10 +338,6 @@ QuicConsumedData ReliableQuicStream::WritevData(
return consumed_data;
}
-FecProtection ReliableQuicStream::GetFecProtection() {
- return fec_policy_ == FEC_PROTECT_ALWAYS ? MUST_FEC_PROTECT : MAY_FEC_PROTECT;
-}
-
void ReliableQuicStream::CloseReadSide() {
if (read_side_closed_) {
return;
« no previous file with comments | « net/quic/reliable_quic_stream.h ('k') | net/quic/reliable_quic_stream_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698