Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(885)

Unified Diff: net/quic/quic_connection.h

Issue 1784903003: Remove FEC from send path. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@114770052
Patch Set: Restore accidentally removed OnRttChanged call Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_chromium_client_stream_test.cc ('k') | net/quic/quic_connection.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_connection.h
diff --git a/net/quic/quic_connection.h b/net/quic/quic_connection.h
index fa17503223d0c167d29881e76fd0274390719c74..48473c672a2a36bc8d1f3676ccbd627a13b72211 100644
--- a/net/quic/quic_connection.h
+++ b/net/quic/quic_connection.h
@@ -344,10 +344,7 @@ class NET_EXPORT_PRIVATE QuicConnection
// Returns a pair with the number of bytes consumed from data, and a boolean
// indicating if the fin bit was consumed. This does not indicate the data
// has been sent on the wire: it may have been turned into a packet and queued
- // if the socket was unexpectedly blocked. |fec_protection| indicates if
- // data is to be FEC protected. Note that data that is sent immediately
- // following MUST_FEC_PROTECT data may get protected by falling within the
- // same FEC group.
+ // if the socket was unexpectedly blocked.
// If |listener| is provided, then it will be informed once ACKs have been
// received for all the packets written in this call.
// The |listener| is not owned by the QuicConnection and must outlive it.
@@ -355,7 +352,6 @@ class NET_EXPORT_PRIVATE QuicConnection
QuicIOVector iov,
QuicStreamOffset offset,
bool fin,
- FecProtection fec_protection,
QuicAckListenerInterface* listener);
// Send a RST_STREAM frame to the peer.
@@ -476,7 +472,6 @@ class NET_EXPORT_PRIVATE QuicConnection
void OnSerializedPacket(SerializedPacket* packet) override;
void OnUnrecoverableError(QuicErrorCode error,
ConnectionCloseSource source) override;
- void OnResetFecGroup() override;
// QuicSentPacketManager::NetworkChangeVisitor
void OnCongestionWindowChange() override;
@@ -561,10 +556,6 @@ class NET_EXPORT_PRIVATE QuicConnection
// remaining unacked packets.
void OnRetransmissionTimeout();
- // Called when a data packet is sent. Starts an alarm if the data sent in
- // |packet_number| was FEC protected.
- void MaybeSetFecAlarm(QuicPacketNumber packet_number);
-
// Retransmits all unacked packets with retransmittable frames if
// |retransmission_type| is ALL_UNACKED_PACKETS, otherwise retransmits only
// initially encrypted packets. Used when the negotiated protocol version is
@@ -978,9 +969,6 @@ class NET_EXPORT_PRIVATE QuicConnection
QuicPacketGenerator packet_generator_;
- // An alarm that fires when an FEC packet should be sent.
- QuicArenaScopedPtr<QuicAlarm> fec_alarm_;
-
// Network idle time before this connection is closed.
QuicTime::Delta idle_network_timeout_;
// The connection will wait this long for the handshake to complete.
« no previous file with comments | « net/quic/quic_chromium_client_stream_test.cc ('k') | net/quic/quic_connection.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698