Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1074)

Unified Diff: src/ast/scopes.cc

Issue 1784893003: ParameterInitializerRewriter must maintain temporary variable order (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/ast/scopes.cc
diff --git a/src/ast/scopes.cc b/src/ast/scopes.cc
index 0032d4aaba9316fb82f9bc8a7720d4c602e416a7..94b3101906e4c9308d53c520897990eec5822383 100644
--- a/src/ast/scopes.cc
+++ b/src/ast/scopes.cc
@@ -564,17 +564,16 @@ Variable* Scope::NewTemporary(const AstRawString* name) {
return var;
}
-
-bool Scope::RemoveTemporary(Variable* var) {
+int Scope::RemoveTemporary(Variable* var) {
// Most likely (always?) any temporary variable we want to remove
// was just added before, so we search backwards.
for (int i = temps_.length(); i-- > 0;) {
if (temps_[i] == var) {
temps_.Remove(i);
- return true;
+ return i;
}
}
- return false;
+ return -1;
}

Powered by Google App Engine
This is Rietveld 408576698