Switch SkDropShaderImageFilter over to new onFilterImage interface

Switch SkDropShaderImageFilter over to new onFilterImage interface

TBR=bsalomon@google.com

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1784863003

Committed: https://skia.googlesource.com/skia/+/0a291c7b7eea1807bd58bdaa60c258fd0ebeb257

[robertphillips, 2016-03-10 15:44:35]

Description was changed from

==========
Switch SkDropShaderImageFilter over to new onFilterImage interface
==========

to

==========
Switch SkDropShaderImageFilter over to new onFilterImage interface
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-03-10 15:45:11]

Description was changed from

==========
Switch SkDropShaderImageFilter over to new onFilterImage interface
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Switch SkDropShaderImageFilter over to new onFilterImage interface

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-03-22 19:50:50]

robertphillips@google.com changed reviewers:
+ bsalomon@google.com, senorblanco@chromium.org, senorblanco@google.com

[Stephen White, 2016-03-22 20:03:27]

LGTM w/nit

https://codereview.chromium.org/1784863003/diff/60001/src/effects/SkDropShado...
File src/effects/SkDropShadowImageFilter.cpp (right):

https://codereview.chromium.org/1784863003/diff/60001/src/effects/SkDropShado...
src/effects/SkDropShadowImageFilter.cpp:62: const SkIRect inputBounds =
SkIRect::MakeXYWH(inputOffset.fX, inputOffset.fY,
Nit: let's use x() and y() if we're using width() and height().

[robertphillips, 2016-03-23 11:34:58]

https://codereview.chromium.org/1784863003/diff/60001/src/effects/SkDropShado...
File src/effects/SkDropShadowImageFilter.cpp (right):

https://codereview.chromium.org/1784863003/diff/60001/src/effects/SkDropShado...
src/effects/SkDropShadowImageFilter.cpp:62: const SkIRect inputBounds =
SkIRect::MakeXYWH(inputOffset.fX, inputOffset.fY,
On 2016/03/22 20:03:27, Stephen White wrote:
> Nit: let's use x() and y() if we're using width() and height().

Done.

[robertphillips, 2016-03-23 11:35:09]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-23 11:35:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1784863003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1784863003/80001

[robertphillips, 2016-03-23 11:45:11]

Description was changed from

==========
Switch SkDropShaderImageFilter over to new onFilterImage interface

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Switch SkDropShaderImageFilter over to new onFilterImage interface

TBR=bsalomon@google.com

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[commit-bot: I haz the power, 2016-03-23 11:45:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-23 11:45:27]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-03-23 11:59:00]

The CQ bit was checked by robertphillips@google.com

[robertphillips, 2016-03-23 11:59:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
senorblanco@chromium.org
Link to the patchset: https://codereview.chromium.org/1784863003/#ps80001
(title: "Use x() & y()")

[commit-bot: I haz the power, 2016-03-23 11:59:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1784863003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1784863003/80001

[commit-bot: I haz the power, 2016-03-23 12:00:03]

Description was changed from

==========
Switch SkDropShaderImageFilter over to new onFilterImage interface

TBR=bsalomon@google.com

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Switch SkDropShaderImageFilter over to new onFilterImage interface

TBR=bsalomon@google.com

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/0a291c7b7eea1807bd58bdaa60c258fd0ebeb257
==========

[commit-bot: I haz the power, 2016-03-23 12:00:04]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/0a291c7b7eea1807bd58bdaa60c258fd0ebeb257

[robertphillips, 2016-03-23 16:15:46]

The image diffs due to this CL result from the new path ultimately calling
drawBitmapRect with kStrict_SrcRectConstraint while the old path was calling
drawBitmap with kFast_SrcRectConstraint.